[PATCH] D89307: [clangd] Disable extract variable for RHS of assignments

2020-10-14 Thread Kadir Cetinkaya via Phabricator via cfe-commits
This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG82a71822a54d: [clangd] Disable extract variable for RHS of assignments (authored by kadircet). Repository: rG LLVM Github Monorepo CHANGES SINCE

[PATCH] D89307: [clangd] Disable extract variable for RHS of assignments

2020-10-13 Thread Adam Czachorowski via Phabricator via cfe-commits
adamcz accepted this revision. adamcz added inline comments. This revision is now accepted and ready to land. Comment at: clang-tools-extra/clangd/refactor/tweaks/ExtractVariable.cpp:400 + // This would just result in duplicating the code. + if (const auto *BO = Parent->ASTNode

[PATCH] D89307: [clangd] Disable extract variable for RHS of assignments

2020-10-13 Thread Kadir Cetinkaya via Phabricator via cfe-commits
kadircet created this revision. kadircet added a reviewer: adamcz. Herald added subscribers: cfe-commits, usaxena95, arphaman. Herald added a project: clang. kadircet requested review of this revision. Herald added subscribers: MaskRay, ilya-biryukov. Repository: rG LLVM Github Monorepo https:/