[PATCH] D89233: [clangd] Refine recoveryAST flags in clangd

2020-10-14 Thread Haojian Wu via Phabricator via cfe-commits
This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG3fcca804b291: [clangd] Refine recoveryAST flags in clangd (authored by hokein). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION h

[PATCH] D89233: [clangd] Refine recoveryAST flags in clangd

2020-10-14 Thread Haojian Wu via Phabricator via cfe-commits
hokein marked an inline comment as done. hokein added inline comments. Comment at: clang-tools-extra/clangd/Compiler.cpp:84 - // Recovery expression currently only works for C++. - if (CI->getLangOpts()->CPlusPlus) { -CI->getLangOpts()->RecoveryAST = Inputs.Opts.BuildReco

[PATCH] D89233: [clangd] Refine recoveryAST flags in clangd

2020-10-14 Thread Haojian Wu via Phabricator via cfe-commits
hokein updated this revision to Diff 298116. hokein added a comment. address comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D89233/new/ https://reviews.llvm.org/D89233 Files: clang-tools-extra/clangd/ClangdServer.h clang-tools-extra/cl

[PATCH] D89233: [clangd] Refine recoveryAST flags in clangd

2020-10-12 Thread Sam McCall via Phabricator via cfe-commits
sammccall accepted this revision. sammccall added a comment. This revision is now accepted and ready to land. This is fine as is, but could consider retiring the flags instead. Comment at: clang-tools-extra/clangd/ClangdServer.h:131 +/// If true, turn on the `-frecovery-ast

[PATCH] D89233: [clangd] Refine recoveryAST flags in clangd

2020-10-12 Thread Haojian Wu via Phabricator via cfe-commits
hokein created this revision. hokein added a reviewer: sammccall. Herald added subscribers: usaxena95, kadircet, arphaman. Herald added a project: clang. hokein requested review of this revision. Herald added subscribers: MaskRay, ilya-biryukov. so that we could start experiment for C. Previously