[PATCH] D89197: [X86] Support -march=x86-64-v[234]

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG012dd42e027e: [X86] Support -march=x86-64-v[234] (authored by MaskRay). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://r

[PATCH] D89197: [X86] Support -march=x86-64-v[234]

RKSimon accepted this revision. RKSimon added a comment. This revision is now accepted and ready to land. LGTM - thank you! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D89197/new/ https://reviews.llvm.org/D89197 __

[PATCH] D89197: [X86] Support -march=x86-64-v[234]

MaskRay updated this revision to Diff 297613. MaskRay added a comment. ReleaseNotes.rst: use `` :doc:`UsersManual` `` Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D89197/new/ https://reviews.llvm.org/D89197 Files: clang/docs/ReleaseNotes.rst c

[PATCH] D89197: [X86] Support -march=x86-64-v[234]

MaskRay updated this revision to Diff 297612. MaskRay added a comment. Update clang/docs/UsersManual.rst Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D89197/new/ https://reviews.llvm.org/D89197 Files: clang/docs/ReleaseNotes.rst clang/docs/Use

[PATCH] D89197: [X86] Support -march=x86-64-v[234]

RKSimon added a comment. I'd prefer that our docs explicitly state what we've implemented instead of just referencing an external webpage. Please add the full explanation to UserManual.rst under the "CPU Architectures Features and Limitations" x86 section for long term reference - the release

[PATCH] D89197: [X86] Support -march=x86-64-v[234]

MaskRay marked an inline comment as done. MaskRay added inline comments. Comment at: clang/docs/ReleaseNotes.rst:191 -- Support for -march=sapphirerapids was added. +* Support for ``-march=sapphirerapids`` and ``-march=x86-64-v[234]`` has been added. RKSimon

[PATCH] D89197: [X86] Support -march=x86-64-v[234]

MaskRay updated this revision to Diff 297606. MaskRay added a comment. Fix bullet point. Add a link to https://gitlab.com/x86-psABIs/x86-64-ABI/-/commit/77566eb03bc6a326811cb7e9 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D89197/new/ https://revi

[PATCH] D89197: [X86] Support -march=x86-64-v[234]

RKSimon added inline comments. Comment at: clang/docs/ReleaseNotes.rst:191 -- Support for -march=sapphirerapids was added. +* Support for ``-march=sapphirerapids`` and ``-march=x86-64-v[234]`` has been added. Fix the bullet point: '-' Please can you extend

[PATCH] D89197: [X86] Support -march=x86-64-v[234]

craig.topper accepted this revision. craig.topper added a comment. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D89197/new/ https://reviews.llvm.org/D89197 ___ cfe-commits mailing list cfe-commits@l

[PATCH] D89197: [X86] Support -march=x86-64-v[234]

MaskRay added a comment. In D89197#2323979 , @craig.topper wrote: > In D89197#2323946 , @MaskRay wrote: > >> Test __LAHF_SAHF__ >> Update clang/docs/ReleaseNotes.rst >> Update clang/test/CodeGen/attr-target-x86.c t

[PATCH] D89197: [X86] Support -march=x86-64-v[234]

craig.topper added a comment. In D89197#2323946 , @MaskRay wrote: > Test __LAHF_SAHF__ > Update clang/docs/ReleaseNotes.rst > Update clang/test/CodeGen/attr-target-x86.c to test X86.td changes. Ideally > "target-features" should be testable with llc to ha

[PATCH] D89197: [X86] Support -march=x86-64-v[234]

MaskRay updated this revision to Diff 297473. MaskRay added a comment. Test __LAHF_SAHF__ Update clang/docs/ReleaseNotes.rst Update clang/test/CodeGen/attr-target-x86.c to test X86.td changes. Ideally "target-features" should be testable with llc to have better layering Repository: rG LLVM Gi

[PATCH] D89197: [X86] Support -march=x86-64-v[234]

MaskRay updated this revision to Diff 297469. MaskRay added a comment. Add release note Fix F16C and BMI of x86-64-v3 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D89197/new/ https://reviews.llvm.org/D89197 Files: clang/lib/Basic/Targets/X86.cpp

[PATCH] D89197: [X86] Support -march=x86-64-v[234]

RKSimon requested changes to this revision. RKSimon added a comment. This revision now requires changes to proceed. Please can you add an entry to the 12.00 release notes describing this? Maybe somewhere in the clang docs as well? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D89197: [X86] Support -march=x86-64-v[234]

craig.topper accepted this revision. craig.topper added a comment. This revision is now accepted and ready to land. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D89197/new/ https://reviews.llvm.org/D89197 _

[PATCH] D89197: [X86] Support -march=x86-64-v[234]

MaskRay added inline comments. Comment at: llvm/lib/Target/X86/X86.td:580 // Nehalem - list NHMFeatures = [FeatureX87, -FeatureCMPXCHG8B, -FeatureCMOV, -Fea

[PATCH] D89197: [X86] Support -march=x86-64-v[234]

MaskRay updated this revision to Diff 297444. MaskRay added a comment. Update X86.td ProcModel Update llvm/test/CodeGen/X86/cpus-other.ll Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D89197/new/ https://reviews.llvm.org/D89197 Files: clang/lib/B

[PATCH] D89197: [X86] Support -march=x86-64-v[234]

craig.topper added a comment. Don't we need a change to X86.td too? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D89197/new/ https://reviews.llvm.org/D89197 ___ cfe-commits mailing list cfe-commits@lists

[PATCH] D89197: [X86] Support -march=x86-64-v[234]

MaskRay added inline comments. Comment at: clang/test/Preprocessor/predefined-arch-macros-x86.c:20 + +/// TODO: __LAHF_SAHF__ +// X86_64_V2: #define __GCC_HAVE_SYNC_COMPARE_AND_SWAP_16 1 I'll add it after D89198 is accepted. Repository: rG LLVM Github Mo

[PATCH] D89197: [X86] Support -march=x86-64-v[234]

MaskRay created this revision. MaskRay added reviewers: craig.topper, efriedma, fweimer, RKSimon, spatel. Herald added subscribers: llvm-commits, cfe-commits, pengfei, jfb, hiraditya. Herald added projects: clang, LLVM. MaskRay requested review of this revision. PR47686. These micro-architecture l