This revision was landed with ongoing or failed builds.
This revision was automatically updated to reflect the committed changes.
Closed by commit rG8f1de22c7681: [clangd] Stop capturing trace args if the
tracer doesn't need them. (authored by sammccall).
Repository:
rG LLVM Github Monorepo
CH
kadircet accepted this revision.
kadircet added a comment.
still LGTM. thanks!
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D89135/new/
https://reviews.llvm.org/D89135
___
cfe-commits mailing list
cfe-co
sammccall updated this revision to Diff 297555.
sammccall marked an inline comment as done.
sammccall added a comment.
address comments
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D89135/new/
https://reviews.llvm.org/D89135
Files:
clang-tools-e
sammccall marked an inline comment as done.
sammccall added inline comments.
Comment at: clang-tools-extra/clangd/support/Trace.cpp:91
public:
-JSONSpan(JSONTracer *Tracer, llvm::StringRef Name, llvm::json::Object
*Args)
+llvm::json::Object Args;
+JSONSpan(JSONTra
kadircet accepted this revision.
kadircet added inline comments.
This revision is now accepted and ready to land.
Comment at: clang-tools-extra/clangd/support/Trace.cpp:91
public:
-JSONSpan(JSONTracer *Tracer, llvm::StringRef Name, llvm::json::Object
*Args)
+llvm::jso
sammccall created this revision.
sammccall added a reviewer: kadircet.
Herald added subscribers: cfe-commits, usaxena95, arphaman.
Herald added a project: clang.
sammccall requested review of this revision.
Herald added subscribers: MaskRay, ilya-biryukov.
The tracer is now expected to allocate+fr
