[PATCH] D88949: DeferredDiagnosticsEmitter crashes

This revision was automatically updated to reflect the committed changes. Closed by commit rGb9225543e844: DeferredDiagnosticsEmitter crashes (authored by glevner, committed by yaxunl). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D88949/new/ https:

[PATCH] D88949: DeferredDiagnosticsEmitter crashes

glevner added a comment. Good enough for us... Thanks, @hans and @yaxunl! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D88949/new/ https://reviews.llvm.org/D88949 ___ cfe-commits mailing list cfe-commits

[PATCH] D88949: DeferredDiagnosticsEmitter crashes

hans added a comment. In D88949#2319392 , @yaxunl wrote: > I can help you commit it to trunk. For cherrypick to release branch, we may > need help of @hans It's most likely too late for 11.0.0, but I will put it on my list of 11.0.1 candidates. Reposi

[PATCH] D88949: DeferredDiagnosticsEmitter crashes

yaxunl added a subscriber: hans. yaxunl added a comment. I can help you commit it to trunk. For cherrypick to release branch, we may need help of @hans Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D88949/new/ https://reviews.llvm.org/D88949 _

[PATCH] D88949: DeferredDiagnosticsEmitter crashes

glevner added a comment. Great. I don't have commit access though. If I did, I would love to commit it to the release branch, which is what we use... Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D88949/new/ https://reviews.llvm.org/D88949 ___

[PATCH] D88949: DeferredDiagnosticsEmitter crashes

yaxunl accepted this revision. yaxunl added a comment. This revision is now accepted and ready to land. LGTM. Thanks. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D88949/new/ https://reviews.llvm.org/D88949

[PATCH] D88949: DeferredDiagnosticsEmitter crashes

glevner added a comment. I'm sorry, but I don't know how to reproduce the problem in isolation. We are JIT-compiling fairly complex C++ code, and the crash //sometimes// occurs when, for example, an included header file is not found... Repository: rG LLVM Github Monorepo CHANGES SINCE LAST

[PATCH] D88949: DeferredDiagnosticsEmitter crashes

yaxunl added a comment. Can we have a lit test? Thanks. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D88949/new/ https://reviews.llvm.org/D88949 ___ cfe-commits mailing list cfe-commits@lists.llvm.org ht

[PATCH] D88949: DeferredDiagnosticsEmitter crashes

glevner added a comment. See https://bugs.llvm.org/show_bug.cgi?id=47742 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D88949/new/ https://reviews.llvm.org/D88949 ___ cfe-commits mailing list cfe-commits@

[PATCH] D88949: DeferredDiagnosticsEmitter crashes

glevner created this revision. glevner added reviewers: lhames, yaxunl. Herald added a project: clang. Herald added a subscriber: cfe-commits. glevner requested review of this revision. Patch VisitCXXDeleteExpr() in clang::UsedDeclVisitor to avoid it crashing when the expression's destroyed type