hubert.reinterpretcast added inline comments.
Comment at: clang/test/CodeGen/zos-alignment.c:114
+union u2 {
+ long :0;
+ short a;
The testing for no-attribute potentially 8-byte aligning zero-width bitfields
in a non-initial position is missing.
``
This revision was automatically updated to reflect the committed changes.
Closed by commit rGc781dc74a8b2: [SystemZ][z/OS] Set default alignment rules
for z/OS target (authored by fanbo-meng, committed by abhina.sreeskantharajan).
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
abhina.sreeskantharajan accepted this revision.
abhina.sreeskantharajan added a comment.
This revision is now accepted and ready to land.
lgtm
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D88845/new/
https://reviews.llvm.org/D88845
___
fanbo-meng updated this revision to Diff 296269.
fanbo-meng added a comment.
fix no newline at end of file
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D88845/new/
https://reviews.llvm.org/D88845
Files:
clang/lib/Basic/Targets/OSTargets.h
clang/test/CodeGen/zos-alignment.c
Index:
fanbo-meng created this revision.
fanbo-meng added reviewers: abhina.sreeskantharajan, hubert.reinterpretcast,
Kai, uweigand.
Herald added a project: clang.
Herald added a subscriber: cfe-commits.
fanbo-meng requested review of this revision.
Set the default alignment control variables for z/OS t