[PATCH] D88831: [clang-tidy] Remove obsolete checker google-runtime-references

hans added a comment. In D88831#2316453 , @lebedev.ri wrote: > @hans it would be nice if this could make it into the release, > removing stuff is usually a pretty safe thing to do :) I think it's too late for this release, sorry. I also don't see any part

[PATCH] D88831: [clang-tidy] Remove obsolete checker google-runtime-references

lebedev.ri added a subscriber: hans. lebedev.ri added a comment. @hans it would be nice if this could make it into the release, removing stuff is usually a pretty safe thing to do :) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D88831/new/ https://

[PATCH] D88831: [clang-tidy] Remove obsolete checker google-runtime-references

This revision was automatically updated to reflect the committed changes. Closed by commit rGd6c9dc3c17e4: [clang-tidy] Remove obsolete checker google-runtime-references (authored by baloghadamsoftware). Changed prior to commit: https://reviews.llvm.org/D88831?vs=296170&id=296416#toc Repositor

[PATCH] D88831: [clang-tidy] Remove obsolete checker google-runtime-references

aaron.ballman added a comment. One request though: can you add a release note about the removal with a brief explanation of why it was removed? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D88831/new/ https://reviews.llvm.org/D88831 _

[PATCH] D88831: [clang-tidy] Remove obsolete checker google-runtime-references

aaron.ballman accepted this revision. aaron.ballman added a comment. LGTM to remove rather than move into `readability` unless someone has a good argument as to why it belongs there. I don't think this pattern makes code more readable in general as it recommends using a more verbose syntax (poin

[PATCH] D88831: [clang-tidy] Remove obsolete checker google-runtime-references

gribozavr2 accepted this revision. gribozavr2 added a comment. This revision is now accepted and ready to land. Google C++ style guide does not have this rule anymore. Thanks for the cleanup! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D88831/new/

[PATCH] D88831: [clang-tidy] Remove obsolete checker google-runtime-references

baloghadamsoftware added a comment. In D88831#2311802 , @lebedev.ri wrote: > In D88831#2311800 , @Eugene.Zelenko > wrote: > >> Does this check make sense in content of other style guides? > > I'd +1 to moving it to

[PATCH] D88831: [clang-tidy] Remove obsolete checker google-runtime-references

lebedev.ri added a comment. In D88831#2311800 , @Eugene.Zelenko wrote: > Does this check make sense in content of other style guides? I'd +1 to moving it to `readability`. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://revie

[PATCH] D88831: [clang-tidy] Remove obsolete checker google-runtime-references

Eugene.Zelenko added a comment. Does this check make sense in content of other style guides? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D88831/new/ https://reviews.llvm.org/D88831 ___ cfe-commits maili

[PATCH] D88831: [clang-tidy] Remove obsolete checker google-runtime-references

baloghadamsoftware created this revision. baloghadamsoftware added reviewers: alexfh, gribozavr2, aaron.ballman. baloghadamsoftware added a project: clang-tools-extra. Herald added subscribers: martong, Charusso, gamesh411, Szelethus, dkrupp, rnkovacs, xazax.hun, whisperity, mgorny. Herald added a