[PATCH] D88567: [clangd] Fix invalid UTF8 when extracting doc comments.

kadircet added inline comments. Comment at: clang-tools-extra/clangd/CodeCompletionStrings.cpp:93 + // Clang requires source to be UTF-8, but doesn't enforce this in comments. + if (!llvm::json::isUTF8(Doc)) +Doc = llvm::json::fixUTF8(Doc); sammccall wrote:

[PATCH] D88567: [clangd] Fix invalid UTF8 when extracting doc comments.

This revision was automatically updated to reflect the committed changes. Closed by commit rG216af81c39d1: [clangd] Fix invalid UTF8 when extracting doc comments. (authored by sammccall). Changed prior to commit: https://reviews.llvm.org/D88567?vs=295265&id=295266#toc Repository: rG LLVM Git

[PATCH] D88567: [clangd] Fix invalid UTF8 when extracting doc comments.

sammccall added a comment. In D88567#2303332 , @kadircet wrote: > thanks, LGTM! > > Should we also have another test for SymbolCollector, to ensure we don't > regress this somehow in the future? We had a SymbolCollector test for the boost case so I modif

[PATCH] D88567: [clangd] Fix invalid UTF8 when extracting doc comments.

kadircet accepted this revision. kadircet added a comment. This revision is now accepted and ready to land. thanks, LGTM! Should we also have another test for SymbolCollector, to ensure we don't regress this somehow in the future? Comment at: clang-tools-extra/clangd/CodeComp

[PATCH] D88567: [clangd] Fix invalid UTF8 when extracting doc comments.

sammccall created this revision. sammccall added a reviewer: kadircet. Herald added subscribers: cfe-commits, usaxena95, arphaman. Herald added a project: clang. sammccall requested review of this revision. Herald added subscribers: MaskRay, ilya-biryukov. Repository: rG LLVM Github Monorepo ht