This revision was automatically updated to reflect the committed changes.
Closed by commit rG45698ac0052a: [clangd] Split DecisionForest Evaluate() into
one func per tree. (authored by usaxena95).
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D88536/n
usaxena95 updated this revision to Diff 295473.
usaxena95 added a comment.
Addressed comments: Move the evaluate functions to anonymous namespace.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D88536/new/
https://reviews.llvm.org/D88536
Files:
cl
usaxena95 added inline comments.
Comment at: clang-tools-extra/clangd/quality/CompletionModelCodegen.py:168
+nline.join(class_members),
+nline.join([" float EvaluateTree%d() const;" % tree_num
+for tree_num in range(num_trees)]),
-
adamcz added inline comments.
Comment at: clang-tools-extra/clangd/quality/CompletionModelCodegen.py:168
+nline.join(class_members),
+nline.join([" float EvaluateTree%d() const;" % tree_num
+for tree_num in range(num_trees)]),
usaxena95 updated this revision to Diff 295284.
usaxena95 added a comment.
Minor formatting fixes.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D88536/new/
https://reviews.llvm.org/D88536
Files:
clang-tools-extra/clangd/quality/CompletionModelCo
usaxena95 created this revision.
Herald added subscribers: cfe-commits, kadircet, arphaman.
Herald added a project: clang.
usaxena95 requested review of this revision.
Herald added subscribers: MaskRay, ilya-biryukov.
This allows us MSAN to instrument this function. Previous version is not
instrum
