[PATCH] D88425: Skip -fPIE for AMDGPU and HIP toolchain

yaxunl added a comment. In D88425#3337003 , @MaskRay wrote: > I plan to default CMake `CLANG_DEFAULT_PIE_ON_LINUX` to on in D120305 > and hip-fpie-option.hip will fail. Do you > mind investigating the issue? You need t

[PATCH] D88425: Skip -fPIE for AMDGPU and HIP toolchain

MaskRay added a comment. I plan to default CMake `CLANG_DEFAULT_PIE_ON_LINUX` to on in D120305 and hip-fpie-option.hip will fail. Do you mind investigating the issue? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/

[PATCH] D88425: Skip -fPIE for AMDGPU and HIP toolchain

This revision was automatically updated to reflect the committed changes. yaxunl marked an inline comment as done. Closed by commit rG10eb3bf2d430: Skip -fPIE for AMDGPU and HIP toolchain (authored by yaxunl). Herald added a project: clang. Changed prior to commit: https://reviews.llvm.org/D884

[PATCH] D88425: Skip -fPIE for AMDGPU and HIP toolchain

yaxunl marked an inline comment as done. yaxunl added inline comments. Comment at: clang/test/Driver/hip-fpie-option.hip:34 + +// DEV-DAG: {{".*clang.*".* "-triple" "amdgcn-amd-amdhsa".* "-mrelocation-model" "pic" "-pic-level" "[1|2]" "-mframe-pointer=all"}} +// HOST-STATIC-DAG:

[PATCH] D88425: Skip -fPIE for AMDGPU and HIP toolchain

tra accepted this revision. tra added a comment. This revision is now accepted and ready to land. LGTM Comment at: clang/test/Driver/hip-fpie-option.hip:34 + +// DEV-DAG: {{".*clang.*".* "-triple" "amdgcn-amd-amdhsa".* "-mrelocation-model" "pic" "-pic-level" "[1|2]" "-mframe-p

[PATCH] D88425: Skip -fPIE for AMDGPU and HIP toolchain

yaxunl created this revision. yaxunl added a reviewer: tra. Herald added subscribers: kerbowa, t-tye, tpr, dstuttard, nhaehnle, jvesely, kzhuravl. yaxunl requested review of this revision. Herald added a subscriber: wdng. AMDGPU toolchain does not support -fPIE, therefore skip it if specified by