This revision was automatically updated to reflect the committed changes.
Closed by commit rGbba96c996555: [clang][AVR] Improve avr-ld command line
options (authored by benshi001).
Changed prior to commit:
https://reviews.llvm.org/D88410?vs=294872&id=305792#toc
Repository:
rG LLVM Github Mon
dylanmckay accepted this revision.
dylanmckay added a comment.
This revision is now accepted and ready to land.
Looks good to me, thanks for the patch @benshi001
NOTE: It looks like you will need to rebase this one prior to merge.
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D88410/new/
aykevl added a comment.
I haven't verified this all but this looks reasonable to me, at least until a
better way is figured out to store MCU specific information in the compiler.
The tests may be a little bit excessive though, they all seem to be testing the
same thing.
CHANGES SINCE LAST ACT
benshi001 added a comment.
ping
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D88410/new/
https://reviews.llvm.org/D88410
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
benshi001 updated this revision to Diff 294872.
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D88410/new/
https://reviews.llvm.org/D88410
Files:
clang/lib/Driver/ToolChains/AVR.cpp
clang/test/Driver/avr-link-mcu-family-unimplemented.c
clang/test/Driver/avr-mmcu.c
Index: clang/test/
benshi001 updated this revision to Diff 294854.
benshi001 edited the summary of this revision.
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D88410/new/
https://reviews.llvm.org/D88410
Files:
clang/lib/Driver/ToolChains/AVR.cpp
clang/test/Driver/avr-link-mcu-family-unimplemented.c
c
benshi001 added a comment.
For some devices, the library sub path "-L" and family name "-m" are not always
equal.
-L/usr/lib/avr/lib/XXX" "-L/usr/lib/gcc/avr/5.4.0/XXX" "-mYYY"
XXX and YYY do not always equal to each other. But current
clang/lib/Driver/ToolChains/AVR.cpp assumes they equal.
Fo
benshi001 created this revision.
benshi001 added reviewers: dylanmckay, aykevl.
Herald added subscribers: cfe-commits, Jim.
Herald added a project: clang.
benshi001 requested review of this revision.
Improve avr-ld options for total 249 devices:
1. the argument of "-L" (device library sub path)
2
