This revision was automatically updated to reflect the committed changes.
Closed by commit rG5011d43108d1: Migrate Declarators to use the List API
(authored by eduucaldas).
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D88403/new/
https://reviews.llv
eduucaldas updated this revision to Diff 295053.
eduucaldas added a comment.
Update tests
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D88403/new/
https://reviews.llvm.org/D88403
Files:
clang/include/clang/Tooling/Syntax/Nodes.h
clang/lib/Tool
eduucaldas updated this revision to Diff 294905.
eduucaldas marked an inline comment as done.
eduucaldas added a comment.
Improve comment
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D88403/new/
https://reviews.llvm.org/D88403
Files:
clang/inclu
eduucaldas marked 3 inline comments as done.
eduucaldas added inline comments.
Comment at: clang/unittests/Tooling/Syntax/BuildTreeTest.cpp:2932
|-'void'
- |-SimpleDeclarator Declarator
- | |-'foo'
- | `-ParametersAndQualifiers
- | |-'(' OpenParen
- | `-')' CloseParen
gribozavr2 added inline comments.
Comment at: clang/lib/Tooling/Syntax/BuildTree.cpp:593
+/// Shrink \p Range to a subrange that only contains tokens of a list.
+ArrayRef shrinkToFitList(ArrayRef Range) {
Comment at: clang/lib/Toolin
eduucaldas added a reviewer: gribozavr2.
eduucaldas added inline comments.
Comment at: clang/lib/Tooling/Syntax/BuildTree.cpp:594
+/// Shrink \p Range to a subrange that only contains tokens of a list.
+ArrayRef shrinkToFitList(ArrayRef Range) {
+ auto BeginChildren
eduucaldas created this revision.
Herald added a project: clang.
Herald added a subscriber: cfe-commits.
eduucaldas requested review of this revision.
After this change all nodes that have a delimited-list are using the
`List` API.
Implementation details:
Let's look at a declaration with multiple
