[PATCH] D88265: Fix comma with half vectors.

fhahn added a comment. In D88265#2303841 , @arames wrote: > In D88265#2302653 , @fhahn wrote: > >> Could you adjust the commit message to be a bit more descriptive, e.g >> something like `[Sema] Support Comma opera

[PATCH] D88265: Fix comma with half vectors.

arames added a comment. In D88265#2302653 , @fhahn wrote: > Could you adjust the commit message to be a bit more descriptive, e.g > something like `[Sema] Support Comma operator for fp16 vectors.` Done! Repository: rG LLVM Github Monorepo CHANGES SI

[PATCH] D88265: Fix comma with half vectors.

arames updated this revision to Diff 295316. arames added a comment. Update commit message. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D88265/new/ https://reviews.llvm.org/D88265 Files: clang/lib/Sema/SemaExpr.cpp clang/test/Sema/fp16vec-sem

[PATCH] D88265: Fix comma with half vectors.

fhahn added a comment. Could you adjust the commit message to be a bit more descriptive, e.g something like `[Sema] Support Comma operator for fp16 vectors.` Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D88265/new/ https://reviews.llvm.org/D88265

[PATCH] D88265: Fix comma with half vectors.

arames added a comment. I do not have commit rights, so it would be great if you can land it. Thanks. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D88265/new/ https://reviews.llvm.org/D88265 ___ cfe-com

[PATCH] D88265: Fix comma with half vectors.

arames updated this revision to Diff 295116. arames added a comment. Address review comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D88265/new/ https://reviews.llvm.org/D88265 Files: clang/lib/Sema/SemaExpr.cpp clang/test/Sema/fp16vec-s

[PATCH] D88265: Fix comma with half vectors.

ahatanak accepted this revision. ahatanak added inline comments. This revision is now accepted and ready to land. Comment at: clang/test/Sema/fp16vec-sema.c:33 + 1, hv0; // expected-warning 2 {{expression result unused}} // Implicit conversion between half vectors and float

[PATCH] D88265: Fix comma with half vectors.

arames updated this revision to Diff 295025. arames marked an inline comment as done. arames added a comment. Addressed review comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D88265/new/ https://reviews.llvm.org/D88265 Files: clang/lib/Se

[PATCH] D88265: Fix comma with half vectors.

arames marked 2 inline comments as done. arames added inline comments. Comment at: clang/test/Sema/fp16vec-sema.c:29 sv0 = hv0 >= hv1; + hv0, 1; // expected-warning 2 {{expression result unused}} sv0 = hv0 || hv1; // expected-error{{logical expression with vector types 'h

[PATCH] D88265: Fix comma with half vectors.

fhahn added inline comments. Comment at: clang/lib/Sema/SemaExpr.cpp:13936 // arm64). - assert(isVector(RHS.get()->getType(), Context.HalfTy) == - isVector(LHS.get()->getType(), Context.HalfTy) && - "both sides are half vectors or neither sides are"); + asser

[PATCH] D88265: Fix comma with half vectors.

arames created this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. arames requested review of this revision. The current half vector was enforcing an assert expecting "(LHS is half vector) == (RHS is half vector)" for comma. Repository: rG LLVM Github Monorep