[PATCH] D88174: [Sema] Address-space sensitive check for unbounded arrays (v2)

chrish_ericsson_atx added a comment. I'm aware that this commit triggers one failure in ASan/Windows -- I have posted a patch for review to address that here: https://reviews.llvm.org/D104141 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D88174/new/

[PATCH] D88174: [Sema] Address-space sensitive check for unbounded arrays (v2)

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGce44fe199bbf: [Sema] Address-space sensitive check for unbounded arrays (v2) (authored by chrish_ericsson_atx). Repository: rG LLVM Github Monorep

[PATCH] D88174: [Sema] Address-space sensitive check for unbounded arrays (v2)

chrish_ericsson_atx updated this revision to Diff 351491. chrish_ericsson_atx added a comment. Corrected APSInt.toString() usage to comply with intervening change 61cdaf66fe22be2b5 Repository: rG LLVM Github Monorepo CHAN

[PATCH] D88174: [Sema] Address-space sensitive check for unbounded arrays (v2)

chrish_ericsson_atx reopened this revision. chrish_ericsson_atx added a comment. This revision is now accepted and ready to land. Reverted commit due to buildbot failures -- will update shortly. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D88174/ne

[PATCH] D88174: [Sema] Address-space sensitive check for unbounded arrays (v2)

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGe42a347b7440: [Sema] Address-space sensitive check for unbounded arrays (v2) (authored by chrish_ericsson_atx). Changed prior to commit: https://r

[PATCH] D88174: [Sema] Address-space sensitive check for unbounded arrays (v2)

aaron.ballman accepted this revision. aaron.ballman added a comment. LGTM! Thank you for the fix. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D88174/new/ https://reviews.llvm.org/D88174 ___ cfe-commits

[PATCH] D88174: [Sema] Address-space sensitive check for unbounded arrays (v2)

chrish_ericsson_atx updated this revision to Diff 350722. chrish_ericsson_atx added a comment. Refreshed previously-reverted changeset and re-tested. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D88174/new/ https://reviews.llvm.org/D88174 Files:

[PATCH] D88174: [Sema] Address-space sensitive check for unbounded arrays (v2)

chrish_ericsson_atx reopened this revision. chrish_ericsson_atx added a comment. This revision is now accepted and ready to land. Reverted due to another obscure test failure. Working to diagnose. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D88174

[PATCH] D88174: [Sema] Address-space sensitive check for unbounded arrays (v2)

This revision was automatically updated to reflect the committed changes. Closed by commit rGd9ee935679e7: [Sema] Address-space sensitive check for unbounded arrays (v2) (authored by chrish_ericsson_atx). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/

[PATCH] D88174: [Sema] Address-space sensitive check for unbounded arrays (v2)

chrish_ericsson_atx added a comment. I'm going to land this as-is, based on Bevin's LGTM and my own confidence that the 10 lines I added are correct (enough). @aaron.ballman , please reopen this review if you have additional comments or concerns. Thanks. Repository: rG LLVM Github Monorepo

[PATCH] D88174: [Sema] Address-space sensitive check for unbounded arrays (v2)

ebevhan accepted this revision. ebevhan added a comment. This revision is now accepted and ready to land. LGTM, but @aaron.ballman should probably give his two cents as well for completion's sake. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D88174

[PATCH] D88174: [Sema] Address-space sensitive check for unbounded arrays (v2)

chrish_ericsson_atx added a comment. Ping. :-) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D88174/new/ https://reviews.llvm.org/D88174 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://li

[PATCH] D88174: [Sema] Address-space sensitive check for unbounded arrays (v2)

chrish_ericsson_atx added inline comments. Comment at: clang/lib/Sema/SemaChecking.cpp:14054 + if (IndexNegated) { +index.setIsUnsigned(false); index = -index; This call to index.setIsUnsigned(false) is the only unreviewed part of this change in this f

[PATCH] D88174: [Sema] Address-space sensitive check for unbounded arrays (v2)

chrish_ericsson_atx created this revision. chrish_ericsson_atx added reviewers: aaron.ballman, rsmith. Herald added a project: clang. Herald added a subscriber: cfe-commits. chrish_ericsson_atx requested review of this revision. Check applied to unbounded (incomplete) arrays and pointers to spot c