eduucaldas abandoned this revision.
eduucaldas added inline comments.
Comment at: clang/include/clang/Tooling/Syntax/Tree.h:252
+ Kind = IteratorKind::NotSentinel;
+ if (isElement(Begin))
+Current = getWithDelimiter(cast(Begin));
Sin
eduucaldas updated this revision to Diff 299348.
eduucaldas added a comment.
rename getBeforeBegin
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D88106/new/
https://reviews.llvm.org/D88106
Files:
clang/include/clang/Tooling/Syntax/Tree.h
clang/
eduucaldas updated this revision to Diff 299347.
eduucaldas marked 2 inline comments as not done.
eduucaldas added a comment.
Add tests, `ElementAndDelimiter` are input iterators
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D88106/new/
https://revi
eduucaldas updated this revision to Diff 298420.
eduucaldas added a comment.
Linting
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D88106/new/
https://reviews.llvm.org/D88106
Files:
clang/include/clang/Tooling/Syntax/Tree.h
clang/lib/Tooling/Sy
eduucaldas updated this revision to Diff 298416.
eduucaldas added a comment.
- [SyntaxTree] `ElementAndDelimiterIterator` is polymorphic and supports
`BeforeBegin` iterator
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D88106/new/
https://reviews.l
eduucaldas added inline comments.
Comment at: clang/include/clang/Tooling/Syntax/Tree.h:241-242
/// "a; b; c" <=> [("a" , ";"), ("b" , ";" ), ("c" , null)]
+ template
+ class ElementAndDelimiterIterator
+ : public llvm::iterator_facade_base<
Since we'
eduucaldas added a comment.
Haven't yet implemented `BeforeBegin`, waiting for a heads up on the patch as
is.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D88106/new/
https://reviews.llvm.org/D88106
___
eduucaldas added inline comments.
Comment at: clang/include/clang/Tooling/Syntax/Tree.h:269
+ return EDI == Other.EDI;
+}
+
gribozavr2 wrote:
> Please also define `operator!=`.
this is defined by the `iterato_facade_base`, take a look at the comments in
eduucaldas updated this revision to Diff 298156.
eduucaldas marked an inline comment as done.
eduucaldas added a comment.
- Make `ElementAndDelimiterIterator` templated.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D88106/new/
https://reviews.llvm.
eduucaldas updated this revision to Diff 297574.
eduucaldas marked 8 inline comments as done.
eduucaldas added a comment.
Answer comments, TODO: think about templated iterators
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D88106/new/
https://review
gribozavr2 added inline comments.
Comment at: clang/include/clang/Tooling/Syntax/Tree.h:211
+ return element == Other.element && delimiter == Other.delimiter;
+}
};
Please also define `operator!=` even if it is not used yet.
Comment
eduucaldas added a reviewer: gribozavr2.
eduucaldas added a comment.
This is quite low priority, compared to the other branches of work, but it was
almost ready work, so I decided to polish it and send it to review now.
Comment at: clang/include/clang/Tooling/Syntax/Tree.h:238
eduucaldas updated this revision to Diff 297006.
eduucaldas added a comment.
Replace `auto .. = std::vector();` with `std::vector ..;`
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D88106/new/
https://reviews.llvm.org/D88106
Files:
clang/include/
eduucaldas updated this revision to Diff 297001.
eduucaldas added a comment.
Reorganize methods to minimize diffs
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D88106/new/
https://reviews.llvm.org/D88106
Files:
clang/include/clang/Tooling/Syntax/
eduucaldas updated this revision to Diff 296996.
eduucaldas added a comment.
Better comments
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D88106/new/
https://reviews.llvm.org/D88106
Files:
clang/include/clang/Tooling/Syntax/Tree.h
clang/lib/To
eduucaldas updated this revision to Diff 296994.
eduucaldas added a comment.
- [SyntaxTree] Provide iterator for `List` that iterates through
`ElementAndDelimiter`s even for not well-defined lists.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D8810
eduucaldas created this revision.
Herald added a project: clang.
Herald added a subscriber: cfe-commits.
eduucaldas requested review of this revision.
Repository:
rG LLVM Github Monorepo
https://reviews.llvm.org/D88106
Files:
clang/include/clang/Tooling/Syntax/Tree.h
clang/lib/Tooling/Synt
17 matches
Mail list logo
