This revision was landed with ongoing or failed builds.
This revision was automatically updated to reflect the committed changes.
JonasToth marked an inline comment as done.
Closed by commit rGe517e5cfec90: [clang] improve accuracy of ExprMutAnalyzer
(authored by JonasToth).
Repository:
rG LLVM
JonasToth marked an inline comment as done.
JonasToth added inline comments.
Comment at: clang/lib/Analysis/ExprMutationAnalyzer.cpp:61
+ // below.
+ auto const ConditionalOperator = conditionalOperator(anyOf(
+ hasTrueExpression(ignoringParens(canResolveToExpr(InnerMatche
JonasToth updated this revision to Diff 297187.
JonasToth added a comment.
- [Feature] add elvis operator detection
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D88088/new/
https://reviews.llvm.org/D88088
Files:
clang/lib/Analysis/ExprMutationAn
aaron.ballman accepted this revision.
aaron.ballman added a comment.
LGTM though I may have spotted a potential improvement (it can be handled in a
follow-up if you want).
Comment at: clang/lib/Analysis/ExprMutationAnalyzer.cpp:61
+ // below.
+ auto const ConditionalOperator
JonasToth updated this revision to Diff 296628.
JonasToth added a comment.
- fix imprecisions
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D88088/new/
https://reviews.llvm.org/D88088
Files:
clang/lib/Analysis/ExprMutationAnalyzer.cpp
clang/uni
JonasToth created this revision.
JonasToth added a reviewer: aaron.ballman.
Herald added subscribers: cfe-commits, ASDenysPetrov, dkrupp, donat.nagy,
Szelethus, jfb, a.sidorin, baloghadamsoftware.
Herald added a project: clang.
JonasToth requested review of this revision.
This patch extracts the
