This revision was landed with ongoing or failed builds.
This revision was automatically updated to reflect the committed changes.
Closed by commit rG2697d138a65a: [Analyzer] GNU named variadic macros in
Plister (authored by chrish_ericsson_atx).
Repository:
rG LLVM Github Monorepo
CHANGES SINC
Szelethus accepted this revision.
Szelethus added a comment.
This revision is now accepted and ready to land.
LGTM! Thanks!
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D87942/new/
https://reviews.llvm.org/D87942
__
chrish_ericsson_atx marked 2 inline comments as done.
chrish_ericsson_atx added a comment.
Thanks for the quick feedback, Kristof! I changed the macro to be just a
decrement operator, and triggered DBZ with that. Added the checks as you
suggested.
Repository:
rG LLVM Github Monorepo
CHANG
chrish_ericsson_atx updated this revision to Diff 293154.
chrish_ericsson_atx added a comment.
Addressed feedback from @Szelethus
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D87942/new/
https://reviews.llvm.org/D87942
Files:
clang/lib/StaticAna
Szelethus added a comment.
The fix is great, thank you so much! The test seems to be annoying, it might be
worth looking into it some other time, but that is definitely orthogonal to
this patch.
Comment at: clang/lib/StaticAnalyzer/Core/PlistDiagnostics.cpp:1211-1212
-
chrish_ericsson_atx added inline comments.
Comment at: clang/test/Analysis/plist-macros-with-expansion.cpp:536
+ do { \
+ } while (0)
+
Seems the do {} while (0) idiom is a problem, because the plist output gets
formatted differently on w
chrish_ericsson_atx created this revision.
chrish_ericsson_atx added reviewers: NoQ, Szelethus, dcoughlin.
Herald added subscribers: cfe-commits, ASDenysPetrov, martong, Charusso,
dkrupp, donat.nagy, mikhail.ramalho, a.sidorin, szepet, baloghadamsoftware,
xazax.hun.
Herald added a project: clang.
