[PATCH] D87928: Provide -fsource-dir flag in Clang

phosek abandoned this revision. phosek added a comment. No longer needed with `-fcoverage-compilation-dir`. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D87928/new/ https://reviews.llvm.org/D87928 ___ cfe-commits mailing list cfe-commits@list

[PATCH] D87928: Provide -fsource-dir flag in Clang

phosek added a comment. I'm picking up this change again after D83154 landed. I did some tracing and it looks like `FileManager` already returns a relative path when relative path was passed to the compiler as you'd expect so I don't think we need to change any

[PATCH] D87928: Provide -fsource-dir flag in Clang

dexonsmith added a comment. In D87928#2396448 , @phosek wrote: > `-fsource-dir` is only used for coverage mapping and macros. Oh, interesting; it would be nice to consistently make all paths relative paths. > Here `out/default` is the working directory s

[PATCH] D87928: Provide -fsource-dir flag in Clang

phosek added a comment. In D87928#2394913 , @dexonsmith wrote: > I missed this before, and it's an interesting problem. > > I have a few questions: > > - I'm not clear on the expected interaction between the current working > directory of the compiler and

[PATCH] D87928: Provide -fsource-dir flag in Clang

dexonsmith added reviewers: Bigcheese, jansvoboda11, arphaman. dexonsmith added a comment. I missed this before, and it's an interesting problem. I have a few questions: - I'm not clear on the expected interaction between the current working directory of the compiler and `-fsource-dir`. What ha

[PATCH] D87928: Provide -fsource-dir flag in Clang

phosek added a comment. Ping? Is it OK to land this? CHANGES SINCE LAST ACTION https://reviews.llvm.org/D87928/new/ https://reviews.llvm.org/D87928 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listi

[PATCH] D87928: Provide -fsource-dir flag in Clang

phosek added a comment. @rnk @vsk does this look good to you as well? CHANGES SINCE LAST ACTION https://reviews.llvm.org/D87928/new/ https://reviews.llvm.org/D87928 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-

[PATCH] D87928: Provide -fsource-dir flag in Clang

phosek updated this revision to Diff 303567. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D87928/new/ https://reviews.llvm.org/D87928 Files: clang/include/clang/Basic/CodeGenOptions.h clang/include/clang/Driver/Options.td clang/include/clang/Lex/PreprocessorOptions.h clang/lib/Co

[PATCH] D87928: Provide -fsource-dir flag in Clang

keith added a comment. In D87928#2282609 , @phosek wrote: > This change is trying to address the issues raised in D83154 > . There are still some open questions: > > - Is `-fsource-dir` the best name for this flag? I thin

[PATCH] D87928: Provide -fsource-dir flag in Clang

phosek added a comment. This change is trying to address the issues raised in D83154 . There are still some open questions: - Is `-fsource-dir` the best name for this flag? - I'm not sure if `make_relative` should be applied to all source paths, or only paths th

[PATCH] D87928: Provide -fsource-dir flag in Clang

phosek created this revision. Herald added subscribers: llvm-commits, cfe-commits, dang, hiraditya. Herald added projects: clang, LLVM. phosek requested review of this revision. Herald added a subscriber: ormris. This flag can be used to relativize source paths againts a given directory. Compared