[PATCH] D87888: [X86] Use inlineasm flag output for the _bittest* intrinsics.

This revision was automatically updated to reflect the committed changes. Closed by commit rG288c5776c9d3: [X86] Use inlineasm flag output for the _bittest* intrinsics. (authored by craig.topper). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D87888/n

[PATCH] D87888: [X86] Use inlineasm flag output for the _bittest* intrinsics.

rnk accepted this revision. rnk added a comment. This revision is now accepted and ready to land. Yep, neat. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D87888/new/ https://reviews.llvm.org/D87888 ___ c

[PATCH] D87888: [X86] Use inlineasm flag output for the _bittest* intrinsics.

RKSimon added a comment. LGTM @rnk ? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D87888/new/ https://reviews.llvm.org/D87888 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.or

[PATCH] D87888: [X86] Use inlineasm flag output for the _bittest* intrinsics.

craig.topper updated this revision to Diff 294593. craig.topper added a comment. Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Rebase and add a backend test file Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D87888/new/ http

[PATCH] D87888: [X86] Use inlineasm flag output for the _bittest* intrinsics.

craig.topper added a comment. In D87888#2285878 , @rnk wrote: > Honestly, I forget exactly what the memory clobber does beyond the > "sideeffect" marker. I would expect LLVM to model these just as external > function calls that could read or write memory

[PATCH] D87888: [X86] Use inlineasm flag output for the _bittest* intrinsics.

rnk added a comment. Honestly, I forget exactly what the memory clobber does beyond the "sideeffect" marker. I would expect LLVM to model these just as external function calls that could read or write memory that is passed to them. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTI

[PATCH] D87888: [X86] Use inlineasm flag output for the _bittest* intrinsics.

craig.topper added a comment. @rnk should this inline asm have a memory clobber on it? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D87888/new/ https://reviews.llvm.org/D87888 ___ cfe-commits mailing lis

[PATCH] D87888: [X86] Use inlineasm flag output for the _bittest* intrinsics.

craig.topper added a comment. In D87888#2281360 , @RKSimon wrote: > Do we have sufficient backend test coverage for this? Taking a closer look, I don't think our coverage is very good. We just have one test for each the 28 condition code strings we suppo

[PATCH] D87888: [X86] Use inlineasm flag output for the _bittest* intrinsics.

RKSimon added a comment. Do we have sufficient backend test coverage for this? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D87888/new/ https://reviews.llvm.org/D87888 ___ cfe-commits mailing list cfe-co

[PATCH] D87888: [X86] Use inlineasm flag output for the _bittest* intrinsics.

craig.topper created this revision. craig.topper added reviewers: rnk, niravd. Herald added a project: clang. craig.topper requested review of this revision. Instead of expliciting emitting a setc in the inline asm instructions, we can use flag output. This allows the backend to use the flag direc