[PATCH] D87774: [flang] Introduce DiagnosticConsumer classes in libflangFrontend

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG8d51d37e0628: [flang] Introduce DiagnosticConsumer classes in libflangFrontend (authored by awarzynski). Repository: rG LLVM Github Monorepo CHAN

[PATCH] D87774: [flang] Introduce DiagnosticConsumer classes in libflangFrontend

sameeranjoshi accepted this revision. sameeranjoshi added a comment. Thanks for patch. Looks good. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D87774/new/ https://reviews.llvm.org/D87774 ___ cfe-commits

[PATCH] D87774: [flang] Introduce DiagnosticConsumer classes in libflangFrontend

CarolineConcatto accepted this revision. CarolineConcatto added a comment. This revision is now accepted and ready to land. Thank you @awarzynski for working on this. It is good because now we do not depend on clang frontend to build flang frontend. LGTM Repository: rG LLVM Github Monorepo C

[PATCH] D87774: [flang] Introduce DiagnosticConsumer classes in libflangFrontend

awarzynski added a comment. Ping :) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D87774/new/ https://reviews.llvm.org/D87774 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org

[PATCH] D87774: [flang] Introduce DiagnosticConsumer classes in libflangFrontend

CarolineConcatto added a comment. Hi Folks, @awarzynski and @kiranchandramohan, Diana was working in an out-of-tree build. This is the patch: https://reviews.llvm.org/D87085 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D87774/new/ https://reviews.

[PATCH] D87774: [flang] Introduce DiagnosticConsumer classes in libflangFrontend

kiranchandramohan added a subscriber: rovka. kiranchandramohan added a comment. In D87774#2298515 , @awarzynski wrote: > In D87774#2293283 , @sameeranjoshi > wrote: > >> Do you know if there are any bots configured

[PATCH] D87774: [flang] Introduce DiagnosticConsumer classes in libflangFrontend

awarzynski updated this revision to Diff 294740. awarzynski marked an inline comment as done. awarzynski added a comment. Address the remaining PR comments, fix test Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D87774/new/ https://reviews.llvm.org/

[PATCH] D87774: [flang] Introduce DiagnosticConsumer classes in libflangFrontend

awarzynski marked 4 inline comments as done. awarzynski added a comment. In D87774#2293283 , @sameeranjoshi wrote: > Do you know if there are any bots configured to handle out-of-tree changes? > That might be helpful to avoid configuration differences and

[PATCH] D87774: [flang] Introduce DiagnosticConsumer classes in libflangFrontend

CarolineConcatto added a comment. Thank you @awarzynski for updating the patch. It looks good to me. I've build it locally and played a little bit. It works fine with gcc9.3. I did not try to build out-of-tree. But I don't see any reason it should not work. I have two minor comments. But besides

[PATCH] D87774: [flang] Introduce DiagnosticConsumer classes in libflangFrontend

sameeranjoshi added inline comments. Comment at: flang/lib/Frontend/TextDiagnosticPrinter.cpp:37 + // this later as we print out the diagnostic to the terminal. + SmallString<100> outStr; + info.FormatDiagnostic(outStr); awarzynski wrote: > awarzynski wrote: >

[PATCH] D87774: [flang] Introduce DiagnosticConsumer classes in libflangFrontend

sameeranjoshi added a comment. In D87774#2292034 , @awarzynski wrote: > @sameeranjoshi Apologies, I missed some of your comments. > > In D87774#2287927 , @sameeranjoshi > wrote: > >> Thanks for working on it. >> Fe

[PATCH] D87774: [flang] Introduce DiagnosticConsumer classes in libflangFrontend

sameeranjoshi added inline comments. Comment at: flang/lib/Frontend/TextDiagnostic.cpp:26 +static const enum llvm::raw_ostream::Colors savedColor = +llvm::raw_ostream::SAVEDCOLOR; + awarzynski wrote: > sameeranjoshi wrote: > > Unless Flang is not changing the

[PATCH] D87774: [flang] Introduce DiagnosticConsumer classes in libflangFrontend

awarzynski updated this revision to Diff 294023. awarzynski added a comment. Rebase on top of master Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D87774/new/ https://reviews.llvm.org/D87774 Files: clang/include/clang/Driver/Options.td flang/in

[PATCH] D87774: [flang] Introduce DiagnosticConsumer classes in libflangFrontend

awarzynski added a comment. @sameeranjoshi Regarding ``, please see https://reviews.llvm.org/D88219. Sadly we missed that when adding that test, sorry! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D87774/new/ https://reviews.llvm.org/D87774

[PATCH] D87774: [flang] Introduce DiagnosticConsumer classes in libflangFrontend

kiranchandramohan added inline comments. Comment at: flang/lib/Frontend/TextDiagnosticPrinter.cpp:24 + +TextDiagnosticPrinter::TextDiagnosticPrinter( +raw_ostream &os, clang::DiagnosticOptions *diags) awarzynski wrote: > sameeranjoshi wrote: > > A silly quest

[PATCH] D87774: [flang] Introduce DiagnosticConsumer classes in libflangFrontend

awarzynski added a comment. In D87774#2287927 , @sameeranjoshi wrote: > Thanks for working on it. > Few comments inline: > > 1. For an out-of-tree build, I see `check-flang` target failing with > > /unittests/Frontend/CompilerInstanceTest.cpp:17:10: fat

[PATCH] D87774: [flang] Introduce DiagnosticConsumer classes in libflangFrontend

awarzynski added a comment. Thank you for reviewing! I think that I've addressed all your comments.. Please see the updated patch. Comment at: clang/include/clang/Driver/Options.td:874 +defm color_diagnostics : OptInFFlag<"color-diagnostics", "Enable", "Disable", " colors in

[PATCH] D87774: [flang] Introduce DiagnosticConsumer classes in libflangFrontend

awarzynski updated this revision to Diff 293780. awarzynski marked 17 inline comments as done. awarzynski added a comment. Move code from Fortran to Fortran::frontend namespace, address PR comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D87774

[PATCH] D87774: [flang] Introduce DiagnosticConsumer classes in libflangFrontend

sameeranjoshi added a comment. Thanks for working on it. Few comments inline: 1. For an out-of-tree build, I see `check-flang` target failing with /unittests/Frontend/CompilerInstanceTest.cpp:17:10: fatal error: filesystem: No such file or directory #include ^~~~ I us

[PATCH] D87774: [flang] Introduce DiagnosticConsumer classes in libflangFrontend

CarolineConcatto added a comment. Thank you @awarzynski for this patch. Very good that you added color feature for Fortran. It is just a shame that we do not test. Is there a way to add a regression test for it? I don't see any inconsistency with what we have on clang side, so it is good. My com

[PATCH] D87774: [flang] Introduce DiagnosticConsumer classes in libflangFrontend

kiranchandramohan added a comment. I had a quick look through this patch. Have a few comments (mostly nits and questions) inline. Comment at: flang/include/flang/Frontend/CompilerInvocation.h:18 + +/// Fill out Opts based on the options given in Args. +/// Nit

[PATCH] D87774: [flang] Introduce DiagnosticConsumer classes in libflangFrontend

awarzynski created this revision. Herald added subscribers: cfe-commits, dang, mgorny. Herald added a reviewer: DavidTruby. Herald added a reviewer: sscalpone. Herald added a project: clang. awarzynski requested review of this revision. Currently Flang uses TextDiagnostic, TextDiagnosticPrinter &