[PATCH] D87701: Do not apply calling conventions to MSVC entry points

eandrews added a comment. In D87701#2280246 , @dmajor wrote: > This broke Firefox builds too, in one of our helper binaries that uses a > `wWinMain`, although I'm having trouble writing a minimal reproducer for it. > Simply making a barebones `wWinMain`

[PATCH] D87701: Do not apply calling conventions to MSVC entry points

dmajor added a comment. This broke Firefox builds too, in one of our helper binaries that uses a `wWinMain`, although I'm having trouble writing a minimal reproducer for it. Simply making a barebones `wWinMain` program doesn't hit the error. If the patch re-lands, please cc me and I'll re-test.

[PATCH] D87701: Do not apply calling conventions to MSVC entry points

akhuang added a comment. whoops, sorry for weird formatting in the previous comment. I'll revert for now. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D87701/new/ https://reviews.llvm.org/D87701 ___ cfe

[PATCH] D87701: Do not apply calling conventions to MSVC entry points

akhuang added a comment. This is causing a link error in the windows chromium build: lld-link: error: undefined symbol: _WinMain@16 >>> referenced by >>> D:\agent\_work\4\s\src\vctools\crt\vcstartup\src\startup\exe_common.inl:102 >>> >>> msvcrtd.lib(exe_winmain.obj):(int __cdecl invoke_main(v

[PATCH] D87701: Do not apply calling conventions to MSVC entry points

eandrews added a comment. In D87701#2274860 , @rnk wrote: > lgtm, thanks. Thanks for taking a look! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D87701/new/ https://reviews.llvm.org/D87701 ___

[PATCH] D87701: Do not apply calling conventions to MSVC entry points

This revision was automatically updated to reflect the committed changes. Closed by commit rG4cff1b40dacf: Do not apply calling conventions to MSVC entry points (authored by eandrews). Herald added a project: clang. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://review

[PATCH] D87701: Do not apply calling conventions to MSVC entry points

rnk accepted this revision. rnk added a comment. This revision is now accepted and ready to land. lgtm, thanks. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D87701/new/ https://reviews.llvm.org/D87701 ___ cfe-commits mailing list cfe-commits@

[PATCH] D87701: Do not apply calling conventions to MSVC entry points

eandrews created this revision. eandrews added reviewers: rnk, erichkeane. eandrews requested review of this revision. Fix link error for MSVC entry points when calling conventions are specified. MSVC entry points should have default calling convention. https://reviews.llvm.org/D87701 Files: