[PATCH] D87669: [clangd] Rainbow Semantic Highlighting

2020-09-18 Thread Alex Zielenski via Phabricator via cfe-commits
alexzielenski added a comment. Hey Sam, Thanks for checking this out! I really like your idea about encoding the variants with binary - as you say it removes the need for any assumption on the server's part for the limit of colors. However, I'd be wary of the fact that most users and theme crea

[PATCH] D87669: [clangd] Rainbow Semantic Highlighting

2020-09-18 Thread Sam McCall via Phabricator via cfe-commits
sammccall added a comment. This is cool! We've had a couple of looks at attributes, but haven't really gotten around to polishing it. (For a submittable version, I think we should avoid introducing more modifiers at the same time, just to avoid getting bogged down in exactly which ones) I like