[PATCH] D87622: [MemProf] Rename HeapProfiler to MemProfiler for consistency

2020-09-14 Thread Teresa Johnson via Phabricator via cfe-commits
This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG226d80ebe20e: [MemProf] Rename HeapProfiler to MemProfiler for consistency (authored by tejohnson). Repository: rG LLVM Github Monorepo CHANGES S

[PATCH] D87622: [MemProf] Rename HeapProfiler to MemProfiler for consistency

2020-09-14 Thread Teresa Johnson via Phabricator via cfe-commits
tejohnson added a comment. In D87622#2271931 , @davidxl wrote: > LGTM (if the option is documented, the documentation part also needs to be > updated). It isn't documented yet, since the generated code won't work until the runtime is in. I will be send

[PATCH] D87622: [MemProf] Rename HeapProfiler to MemProfiler for consistency

2020-09-14 Thread David Li via Phabricator via cfe-commits
davidxl accepted this revision. davidxl added a comment. This revision is now accepted and ready to land. LGTM (if the option is documented, the documentation part also needs to be updated). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D87622/new/

[PATCH] D87622: [MemProf] Rename HeapProfiler to MemProfiler for consistency (NFC)

2020-09-14 Thread Teresa Johnson via Phabricator via cfe-commits
tejohnson added a comment. In D87622#2271861 , @MaskRay wrote: > LG. (Nit: technically this is not NFC: it affects command line options and > runtime function names (ABI changes).) Fair enough, will remove that. Repository: rG LLVM Github Monorepo C

[PATCH] D87622: [MemProf] Rename HeapProfiler to MemProfiler for consistency (NFC)

2020-09-14 Thread Fangrui Song via Phabricator via cfe-commits
MaskRay added a comment. LG. (Nit: technically this is not NFC: it affects command line options and runtime function names (ABI changes).) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D87622/new/ https://reviews.llvm.org/D87622 __

[PATCH] D87622: [MemProf] Rename HeapProfiler to MemProfiler for consistency (NFC)

2020-09-14 Thread Teresa Johnson via Phabricator via cfe-commits
tejohnson created this revision. tejohnson added a reviewer: davidxl. Herald added subscribers: jfb, hiraditya, mgorny. Herald added projects: clang, LLVM. tejohnson requested review of this revision. This is consistent with the clang option added in 7ed8124d46f94601d5f1364becee9cee8538265e