This revision was automatically updated to reflect the committed changes.
Closed by commit rGcc76965b1908: [MinGW] Use lib prefix for libraries (authored
by mati865, committed by mstorsjo).
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D87517/new/
ht
mati865 added a comment.
`-DLLVM_ENABLE_PROJECTS="clang;lldb" -DLLVM_BUILD_LLVM_DYLIB=1` with only this
patch applied (`<` is before, `>` is after):
$ diff <(cd ../build && find ./ | sort) <(cd ../build2/ && find ./ | sort)
38a39,41
> ./bin/libLLVM.dll
> ./bin/libLTO.dll
> ./bin/libRem
mstorsjo accepted this revision.
mstorsjo added a comment.
This revision is now accepted and ready to land.
This looks good to me! I can push it later.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D87517/new/
https://reviews.llvm.org/D87517
__
mati865 added a comment.
I haven't tried ` BUILD_SHARED_LIBS=TRUE` TBH.
Effects visible at first glance:
bin/LLVM.dll -> bin/libLLVM.dll
bin/LTO.dll -> bin/libLTO.dll
lib/liblibclang.a -> lib/libclang.a
lib/liblibclang.dll.a -> lib/libclang.a
lib/libliblldb.d
mstorsjo added a comment.
Herald added a reviewer: JDevlieghere.
What's the practical effect of this? I see that a number of libraries already
have a lib prefix prepended, like libclang/liblldb - I presume this changes the
name of the individual libs (for BUILD_SHARED_LIBS=TRUE configurations)?
mati865 updated this revision to Diff 291224.
mati865 added a comment.
Also adjusted llvm-config.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D87517/new/
https://reviews.llvm.org/D87517
Files:
clang/tools/libclang/CMakeLists.txt
lldb/source/A
mati865 created this revision.
mati865 added a reviewer: LLVM.
mati865 added projects: LLVM, clang, LLDB.
Herald added subscribers: llvm-commits, lldb-commits, cfe-commits,
JDevlieghere, mgorny.
mati865 requested review of this revision.
In MinGW world, UNIX like `lib` prefix is preferred. This p
