[PATCH] D87372: clang-cl: Ignore /Zc:externConstexpr and /Zc:throwingNew

2020-11-05 Thread Hans Wennborg via Phabricator via cfe-commits
hans added a comment. In D87372#2376305 , @ki.stfu wrote: > @hans they are ignored because Clang behaves like MSVC with these options > enabled (C++ standard conformance mode) Ah, I got it backwards. Yeah, ignoring these makes sense. Can you add the vari

Re: [PATCH] D87372: clang-cl: Ignore /Zc:externConstexpr and /Zc:throwingNew

2020-11-05 Thread Ilia K via cfe-commits
@hans they are ignored because Clang behaves like MSVC with these options enabled (C++ standard conformance mode) On Wed, Nov 4, 2020, 16:03 Hans Wennborg via Phabricator < revi...@reviews.llvm.org> wrote: > hans added a comment. > > I'm not sure ignoring these is the right thing to do. Maybe th

[PATCH] D87372: clang-cl: Ignore /Zc:externConstexpr and /Zc:throwingNew

2020-11-04 Thread Hans Wennborg via Phabricator via cfe-commits
hans added a comment. I'm not sure ignoring these is the right thing to do. Maybe they should be "Unsupported but parsed options" instead? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D87372/new/ https://reviews.llvm.org/D87372 _

[PATCH] D87372: clang-cl: Ignore /Zc:externConstexpr and /Zc:throwingNew

2020-10-12 Thread Ilia K via Phabricator via cfe-commits
ki.stfu added a comment. @rsmith Friendly ping. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D87372/new/ https://reviews.llvm.org/D87372 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://li

[PATCH] D87372: clang-cl: Ignore /Zc:externConstexpr and /Zc:throwingNew

2020-09-09 Thread Ilia K via Phabricator via cfe-commits
ki.stfu added a comment. Not sure, but I'd be surprised if Clang behaves like MSVC in one of these cases. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D87372/new/ https://reviews.llvm.org/D87372 ___ cfe-

[PATCH] D87372: clang-cl: Ignore /Zc:externConstexpr and /Zc:throwingNew

2020-09-09 Thread Ilia K via Phabricator via cfe-commits
ki.stfu created this revision. ki.stfu added a reviewer: rsmith. Herald added subscribers: cfe-commits, dang. Herald added a project: clang. ki.stfu requested review of this revision. The first option tells the compiler to use external linkage for `constexpr` variables, and the second one prevent