This revision was automatically updated to reflect the committed changes.
bader marked an inline comment as done.
Closed by commit rG9263931fcccd: [SYCL] Assume SYCL device functions are
convergent (authored by bader).
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://rev
bader updated this revision to Diff 294931.
bader added a comment.
Applied Ronan's suggestion.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D87282/new/
https://reviews.llvm.org/D87282
Files:
clang/lib/Frontend/CompilerInvocation.cpp
clang/test
Naghasan accepted this revision.
Naghasan added a comment.
This revision is now accepted and ready to land.
Change make sense to me (same rational as CUDA or OpenCL).
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D87282/new/
https://reviews.llvm.org
keryell added a comment.
Be lazy
Comment at: clang/test/CodeGenSYCL/convergent.cpp:18
+int main() {
+ kernel_single_task([]() { foo(); });
+ return 0;
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D87282/new/
bader created this revision.
Herald added subscribers: cfe-commits, Anastasia, ebevhan, yaxunl.
Herald added a project: clang.
bader requested review of this revision.
SYCL device compiler (similar to other SPMD compilers) assumes that
functions are convergent by default to avoid invalid transform
