This revision was landed with ongoing or failed builds.
This revision was automatically updated to reflect the committed changes.
Closed by commit rGf5087d5c7248: [SyntaxTree] Fix crash on functions with
default arguments. (authored by eduucaldas).
Repository:
rG LLVM Github Monorepo
CHANGES S
eduucaldas updated this revision to Diff 290439.
eduucaldas added a comment.
Test init declarator with default arguments
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D87249/new/
https://reviews.llvm.org/D87249
Files:
clang/lib/Tooling/Syntax/Bui
gribozavr2 accepted this revision.
gribozavr2 added inline comments.
This revision is now accepted and ready to land.
Comment at: clang/unittests/Tooling/Syntax/BuildTreeTest.cpp:4177
+ auto x1 = [[X(1)]];
+ auto x2 = [[X(1, '2')]];
+}
Please also add tests tha
eduucaldas updated this revision to Diff 290410.
eduucaldas added a comment.
Add tests for constructor calls
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D87249/new/
https://reviews.llvm.org/D87249
Files:
clang/lib/Tooling/Syntax/BuildTree.cpp
gribozavr2 added a comment.
Please also add tests for calls to constructors without arguments and calls to
implicit constructors 1 argument, as requested in
https://reviews.llvm.org/D86700.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D87249/new/
eduucaldas created this revision.
eduucaldas added a reviewer: gribozavr2.
Herald added a project: clang.
Herald added a subscriber: cfe-commits.
eduucaldas requested review of this revision.
- Do not visit `CXXDefaultArgExpr`
- To build `CallArguments` nodes, just go through non-default arguments
