bc-lee added a comment.
Thanks for the review. Since I don't have commit access, so I want someone else
to apply this patch.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D87201/new/
https://reviews.llvm.org/D87201
This revision was automatically updated to reflect the committed changes.
Closed by commit rG2e7add812eb7: [clang-format] Add a option for the position
of Java static import (authored by MyDeveloperDay).
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D
bc-lee added a comment.
Can someone commit my changes on behalf of it?
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D87201/new/
https://reviews.llvm.org/D87201
___
cfe-commits mailing list
cfe-commits@li
bc-lee marked an inline comment as done.
bc-lee added a comment.
It's okay for some reviewers to make this change on my behalf. Thanks for
reviewing this!
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D87201/new/
https://reviews.llvm.org/D87201
__
JakeMerdichAMD accepted this revision.
JakeMerdichAMD added a comment.
This revision is now accepted and ready to land.
Sorry on the delay, LGTM too.
It looks like you're a first time contributor and probably don't have write
access to the repo, do you want one of us to push this on your behalf?
MyDeveloperDay accepted this revision.
MyDeveloperDay added a comment.
LGTM, I'm happy if @JakeMerdichAMD is
Comment at: clang/include/clang/Format/Format.h:1708
+ /// \endcode
+ bool JavaStaticImportAfterImport;
+
bc-lee wrote:
> JakeMerdichAMD wrote:
> > M
bc-lee added inline comments.
Comment at: clang/docs/ClangFormatStyleOptions.rst:1970
+ but this behavior is changed by another option,
+ ``JavaStaticImportAfterImport``.
MyDeveloperDay wrote:
> Can you add a test that shows if the sorting is still in the gro
bc-lee updated this revision to Diff 290619.
bc-lee added a comment.
Add more tests and rename options.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D87201/new/
https://reviews.llvm.org/D87201
Files:
clang/docs/ClangFormatStyleOptions.rst
clan
JakeMerdichAMD added inline comments.
Comment at: clang/include/clang/Format/Format.h:1708
+ /// \endcode
+ bool JavaStaticImportAfterImport;
+
MyDeveloperDay wrote:
> Can we consider changing the name or the option to make it clearer what its
> for?
>
> `Sor
MyDeveloperDay added inline comments.
Comment at: clang/docs/ClangFormatStyleOptions.rst:1970
+ but this behavior is changed by another option,
+ ``JavaStaticImportAfterImport``.
Can you add a test that shows if the sorting is still in the groups, i.e. I
can
bc-lee updated this revision to Diff 290381.
bc-lee added a comment.
Fix the example to match the description.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D87201/new/
https://reviews.llvm.org/D87201
Files:
clang/docs/ClangFormatStyleOptions.rst
JakeMerdichAMD added inline comments.
Comment at: clang/include/clang/Format/Format.h:1705
+ /// \endcode
+ bool JavaStaticImportAfterImport;
+
bc-lee wrote:
> JakeMerdichAMD wrote:
> > 3 things here:
> >
> > 1. Did you mix up the true and false cases?
> > 2.
bc-lee updated this revision to Diff 290303.
bc-lee added a comment.
Some comments have been corrected and a unittest has been added in
FormatTest.ParsesConfigurationBools
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D87201/new/
https://reviews.ll
bc-lee added inline comments.
Comment at: clang/docs/ClangFormatStyleOptions.rst:2027
+
+ .. code-block:: java
+ true:
MyDeveloperDay wrote:
> The ClangFormatStyleOptions.rst is generated using
> doc/tools/dump_format_style.py which reads Format.h and genera
JakeMerdichAMD requested changes to this revision.
JakeMerdichAMD added inline comments.
This revision now requires changes to proceed.
Comment at: clang/include/clang/Format/Format.h:1705
+ /// \endcode
+ bool JavaStaticImportAfterImport;
+
3 things here:
1.
bc-lee updated this revision to Diff 290246.
bc-lee added a comment.
Modify the comment of Format.h to sync ClangFormatStyleOptions.rst
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D87201/new/
https://reviews.llvm.org/D87201
Files:
clang/docs/Cl
MyDeveloperDay requested changes to this revision.
MyDeveloperDay added a comment.
This revision now requires changes to proceed.
Thanks for the patch, You need to generate a fill context diff (see
Contributing to LLVM)
ensure the diff is clang-formatted itself (can't quite tell if it is or not)
bc-lee updated this revision to Diff 290137.
bc-lee added a comment.
Add missing initializer.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D87201/new/
https://reviews.llvm.org/D87201
Files:
clang/docs/ClangFormatStyleOptions.rst
clang/include/
bc-lee created this revision.
bc-lee added a reviewer: MyDeveloperDay.
bc-lee added projects: clang, clang-format.
Herald added a subscriber: cfe-commits.
bc-lee requested review of this revision.
Some Java style guides and IDEs group Java static imports after
non-static imports. This patch allow
19 matches
Mail list logo
