arichardson added inline comments.
Comment at: clang/lib/CMakeLists.txt:24
add_subdirectory(IndexSerialization)
-if(CLANG_ENABLE_STATIC_ANALYZER)
- add_subdirectory(StaticAnalyzer)
arichardson wrote:
> thakis wrote:
> > hans wrote:
> > > Why does removing the c
arichardson added inline comments.
Herald added subscribers: manas, steakhal.
Herald added a project: clang-tools-extra.
Comment at: clang/lib/CMakeLists.txt:24
add_subdirectory(IndexSerialization)
-if(CLANG_ENABLE_STATIC_ANALYZER)
- add_subdirectory(StaticAnalyzer)
---
hans accepted this revision.
hans added a comment.
This revision is now accepted and ready to land.
lgtm
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D87118/new/
https://reviews.llvm.org/D87118
___
cfe-commits mailing list
cfe-commits@lists.l
thakis added inline comments.
Comment at: llvm/utils/gn/secondary/clang-tools-extra/clang-tidy/BUILD.gn:18
+ } else {
+values += [ "CLANG_TIDY_ENABLE_STATIC_ANALYZER=" ]
+ }
thakis wrote:
> thakis wrote:
> > hans wrote:
> > > Why not =0?
> > Because it's a
thakis added inline comments.
Comment at: llvm/utils/gn/secondary/clang-tools-extra/clang-tidy/BUILD.gn:18
+ } else {
+values += [ "CLANG_TIDY_ENABLE_STATIC_ANALYZER=" ]
+ }
thakis wrote:
> hans wrote:
> > Why not =0?
> Because it's a #cmakedefine01, and th
thakis added inline comments.
Comment at: clang-tools-extra/CMakeLists.txt:4
+option(CLANG_TIDY_ENABLE_STATIC_ANALYZER
+ "Include static analyzer checks in clang-tidy" ON)
+
hans wrote:
> Should this default to CLANG_ENABLE_STATIC_ANALYZER instead of ON?
I had t
Szelethus added a reviewer: NoQ.
Szelethus added a comment.
Herald added a subscriber: Charusso.
NoQ in particular has been working hard on the common infrastructure in between
the static analyzer and clang-tidy, I'll add him :)
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D87118/new/
hans added a comment.
Cool!
Comment at: clang-tools-extra/CMakeLists.txt:4
+option(CLANG_TIDY_ENABLE_STATIC_ANALYZER
+ "Include static analyzer checks in clang-tidy" ON)
+
Should this default to CLANG_ENABLE_STATIC_ANALYZER instead of ON?
Co
thakis created this revision.
thakis added a reviewer: hans.
Herald added subscribers: llvm-commits, ASDenysPetrov, dkrupp, donat.nagy,
Szelethus, a.sidorin, baloghadamsoftware, mgorny.
Herald added a project: LLVM.
thakis requested review of this revision.
Instead of using CLANG_ENABLE_STATIC_AN
