This revision was automatically updated to reflect the committed changes.
Closed by commit rGcc6713a2c35e: Thread safety analysis: Test and document
release_generic_capability (authored by aaronpuchert).
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D
aaron.ballman accepted this revision.
aaron.ballman added a comment.
LGTM!
Comment at: clang/docs/ThreadSafetyAnalysis.rst:804
+ #define RELEASE_GENERIC(...) \
+THREAD_ANNOTATION_ATTRIBUTE__(release_generic_capability(__VA_ARGS__))
+
This is not something
aaronpuchert updated this revision to Diff 290045.
aaronpuchert added a comment.
Add some prose, not just code. Otherwise our list of attributes would be
incomplete.
@aaron.ballman, I think you should have another look. Sorry for missing that in
my first patch.
Repository:
rG LLVM Github Mo
aaron.ballman accepted this revision.
aaron.ballman added a comment.
This revision is now accepted and ready to land.
LGTM!
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D87064/new/
https://reviews.llvm.org/D87064
__
aaronpuchert created this revision.
aaronpuchert added a reviewer: aaron.ballman.
Herald added a project: clang.
Herald added a subscriber: cfe-commits.
aaronpuchert requested review of this revision.
The old locking attributes had a generic release, but as it turns out
the capability-based attrib