This revision was not accepted when it landed; it landed in state "Needs
Review".
This revision was automatically updated to reflect the committed changes.
Closed by commit rG215ed9b33ccb: Adapt CastExpr::getSubExprAsWritten to
ConstantExpr (authored by sberg).
Repository:
rG LLVM Github Monor
sberg added a comment.
Ping; OK to submit? (I meanwhile also get this when compiling some code with
plain Clang, not just with the LibreOffice Clang plugin where I saw it
originally.)
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D87030/new/
https://reviews.llvm.org/D87030
__
sberg added a comment.
ping
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D87030/new/
https://reviews.llvm.org/D87030
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
sberg added a comment.
ping
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D87030/new/
https://reviews.llvm.org/D87030
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
sberg added a comment.
friendly ping
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D87030/new/
https://reviews.llvm.org/D87030
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
sberg added a comment.
ping^2
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D87030/new/
https://reviews.llvm.org/D87030
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
sberg updated this revision to Diff 292728.
sberg added a comment.
ping
(addressed the clang-tidy nitpick)
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D87030/new/
https://reviews.llvm.org/D87030
Files:
clang/lib/AST/Expr.cpp
clang/unittests/Tooling/CastExprTest.cpp
Index: clang
sberg added a comment.
I hit this with a call to getSubExprAsWriten from the LibreOffice Clang plugin,
have no idea whether it can be hit from within the compiler itself. Not sure
if clang/unittests/Tooling/CastExprTest.cpp is the best place to add a test for
it.
Repository:
rG LLVM Github
sberg created this revision.
sberg added a reviewer: rsmith.
Herald added a project: clang.
sberg requested review of this revision.
Repository:
rG LLVM Github Monorepo
https://reviews.llvm.org/D87030
Files:
clang/lib/AST/Expr.cpp
clang/unittests/Tooling/CastExprTest.cpp
Index: clang/uni
