This revision was landed with ongoing or failed builds.
This revision was automatically updated to reflect the committed changes.
Closed by commit rGb1f394862053: Do not emit "-tune-cpu generic" for
PS4 platform (authored by dyung).
Changed prior to commit:
https://reviews.llvm.org/D86965?vs=28
probinson accepted this revision.
probinson added a comment.
This revision is now accepted and ready to land.
Couple of nits and LGTM.
Comment at: clang/lib/Driver/ToolChains/Clang.cpp:2078
- // Default to "generic" unless -march is present.
+ // Default to "generic" unless
dyung created this revision.
dyung added a reviewer: probinson.
dyung added a project: clang.
dyung requested review of this revision.
For the PS4, do not emit "-tune-cpu generic" since the platform only has 1
known CPU and we do not want to prevent optimizations by tuning for a generic
rather t
