dblaikie added a comment.
Could this be done with a custom matcher, perhaps? (might be a bit tidier than
macros with __FILE__ and __LINE__ manually handled, etc?
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D86926/new/
https://reviews.llvm.org/D86
This revision was automatically updated to reflect the committed changes.
Closed by commit rG2108bceceb5e: FormatTest: Provide real line number in
failure messages (authored by arichardson).
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D86926/new/
h
MyDeveloperDay accepted this revision.
MyDeveloperDay added a comment.
This revision is now accepted and ready to land.
This LGTM, I've certainly been bit myself in the past with not knowing which
test actually failed especially when they are all foo() something.. thank you
Repository:
rG LLV
arichardson updated this revision to Diff 289181.
arichardson added a comment.
- fix missing argument
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D86926/new/
https://reviews.llvm.org/D86926
Files:
clang/unittests/Format/FormatTest.cpp
Index:
arichardson added inline comments.
Comment at: clang/unittests/Format/FormatTest.cpp:23
using clang::tooling::toReplacements;
+using testing::internal::ScopedTrace;
This is an internal class in the current gtest.h, but upstream has now included
it in the publ
arichardson added inline comments.
Comment at: clang/unittests/Format/FormatTest.cpp:69
- void verifyFormat(llvm::StringRef Expected, llvm::StringRef Code,
-const FormatStyle &Style = getLLVMStyle()) {
+ void _verifyFormat(const char *File, int Line, llvm:
MyDeveloperDay added inline comments.
Comment at: clang/unittests/Format/FormatTest.cpp:69
- void verifyFormat(llvm::StringRef Expected, llvm::StringRef Code,
-const FormatStyle &Style = getLLVMStyle()) {
+ void _verifyFormat(const char *File, int Line, ll
arichardson created this revision.
arichardson added reviewers: MyDeveloperDay, JakeMerdichAMD, sammccall,
curdeius.
Herald added a project: clang.
Herald added a subscriber: cfe-commits.
arichardson requested review of this revision.
Currently a test failure always reports a line number inside v
