bruno added a comment.
I forgot to follow up, but LGTM too.
> @rsmith, @v.g.vassilev hey I stamped this patch assuming it looks ok. But
> definitely shout at me if more feedback needs to be addressed. Happy to
> follow up.
FWIW, this has been working on our code base for sometime now.
Reposi
lxfind added a comment.
@rsmith, @v.g.vassilev hey I stamped this patch assuming it looks ok. But
definitely shout at me if more feedback needs to be addressed. Happy to follow
up.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D86853/new/
https://
This revision was automatically updated to reflect the committed changes.
Closed by commit rGc6c8d4a13ebd: [modules] Fix crash in call to
`FunctionDecl::setPure()` (authored by andrewjcg, committed by lxfind).
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm
andrewjcg updated this revision to Diff 289506.
andrewjcg marked 2 inline comments as done.
andrewjcg added a comment.
feedback
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D86853/new/
https://reviews.llvm.org/D86853
Files:
clang/lib/Serializati
bruno added reviewers: rsmith, v.g.vassilev.
bruno added inline comments.
Comment at: clang/lib/Serialization/ASTReaderDecl.cpp:870
+ // definition (which is required for `setPure`).
+ const bool pure = Record.readInt();
FD->setHasInheritedPrototype(Record.readInt());
--
