[PATCH] D86841: [clang] Adds noprogress attribute deduction for infinite loops

2020-08-29 Thread Atmn Patel via Phabricator via cfe-commits
atmnpatel updated this revision to Diff 288818. atmnpatel added a comment. Fixed comment in C++ test. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D86841/new/ https://reviews.llvm.org/D86841 Files: clang/lib/CodeGen/CGLoopInfo.cpp clang/lib/Co

[PATCH] D86841: [clang] Adds noprogress attribute deduction for infinite loops

2020-08-29 Thread Atmn Patel via Phabricator via cfe-commits
atmnpatel updated this revision to Diff 288817. atmnpatel edited the summary of this revision. atmnpatel added a comment. Sorry, Fixed the test, added a C++ test. I checked the C++, OpenCL C, and OpenCL C++ specs and couldn't find anything that diverged from C spec in this regard, but none of th

[PATCH] D86841: [clang] Adds noprogress attribute deduction for infinite loops

2020-08-29 Thread Roman Lebedev via Phabricator via cfe-commits
lebedev.ri added a comment. Does that wording apply to both the C and C++ (OpenCL?)? Regardless, might be good to test that. Comment at: clang/test/CodeGen/attr-noprogress.c:1-2 +// RUN: %clang_cc1 -S -emit-llvm %s -o - | grep " noprogress " | count 1 +// RUN: %clang_cc1 -S -em

[PATCH] D86841: [clang] Adds noprogress attribute deduction for infinite loops

2020-08-29 Thread Atmn Patel via Phabricator via cfe-commits
atmnpatel created this revision. atmnpatel added reviewers: jdoerfert, aqjune, RalfJung. Herald added subscribers: cfe-commits, danielkiss. Herald added a project: clang. atmnpatel requested review of this revision. The `noprogress` LLVM IR attribute currently under discussion is deduced for func