[PATCH] D86713: [clang-format] Parse nullability attributes as a pointer qualifier

2020-09-01 Thread Alexander Richardson via Phabricator via cfe-commits
arichardson added a comment. In D86713#2242381 , @arichardson wrote: > In D86713#2242354 , @JakeMerdichAMD > wrote: > >> In D86713#2242300 , @arichardson >> wrote: >> >>> I

[PATCH] D86713: [clang-format] Parse nullability attributes as a pointer qualifier

2020-08-28 Thread Alexander Richardson via Phabricator via cfe-commits
This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGd304360decef: [clang-format] Parse nullability attributes as a pointer qualifier (authored by arichardson). Repository: rG LLVM Github Monorepo C

[PATCH] D86713: [clang-format] Parse nullability attributes as a pointer qualifier

2020-08-27 Thread Alexander Richardson via Phabricator via cfe-commits
arichardson added a comment. In D86713#2242354 , @JakeMerdichAMD wrote: > In D86713#2242300 , @arichardson > wrote: > >> In D86713#2242253 , @JakeMerdichAMD >> wrote: >> >

[PATCH] D86713: [clang-format] Parse nullability attributes as a pointer qualifier

2020-08-27 Thread Jake Merdich via Phabricator via cfe-commits
JakeMerdichAMD added a comment. In D86713#2242300 , @arichardson wrote: > In D86713#2242253 , @JakeMerdichAMD > wrote: > >> LGTM, again assuming tests pass locally (patch did not resolve). >> >> Out of curiosity, i

[PATCH] D86713: [clang-format] Parse nullability attributes as a pointer qualifier

2020-08-27 Thread Alexander Richardson via Phabricator via cfe-commits
arichardson added a comment. In D86713#2242253 , @JakeMerdichAMD wrote: > LGTM, again assuming tests pass locally (patch did not resolve). > > Out of curiosity, is _Atomic on your radar? I found some code in clang proper > that handled restrict and _Atom

[PATCH] D86713: [clang-format] Parse nullability attributes as a pointer qualifier

2020-08-27 Thread Jake Merdich via Phabricator via cfe-commits
JakeMerdichAMD accepted this revision. JakeMerdichAMD added a comment. This revision is now accepted and ready to land. LGTM, again assuming tests pass locally (patch did not resolve). Out of curiosity, is _Atomic on your radar? I found some code in clang proper that handled restrict and _Atomic

[PATCH] D86713: [clang-format] Parse nullability attributes as a pointer qualifier

2020-08-27 Thread Alexander Richardson via Phabricator via cfe-commits
arichardson created this revision. arichardson added reviewers: MyDeveloperDay, JakeMerdichAMD, sammccall, curdeius. Herald added a project: clang. Herald added a subscriber: cfe-commits. arichardson requested review of this revision. Before: void f() { MACRO(A * _Nonnull a); } void f() { MACRO(A