This revision was landed with ongoing or failed builds.
This revision was automatically updated to reflect the committed changes.
Closed by commit rG2de2ca348dfa: [SyntaxTree] Add support for `CallExpression`
(authored by eduucaldas).
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTI
eduucaldas added inline comments.
Comment at: clang/lib/Tooling/Syntax/BuildTree.cpp:1070
+Builder.markChildToken(
+std::next(Builder.findToken(S->getCallee()->getEndLoc())),
+syntax::NodeRole::OpenParen);
gribozavr2 wrote:
> Could you add an
eduucaldas updated this revision to Diff 287842.
eduucaldas marked 8 inline comments as done.
eduucaldas added a comment.
Answer code review, squash commits
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D86544/new/
https://reviews.llvm.org/D86544
F
gribozavr2 accepted this revision.
gribozavr2 added inline comments.
This revision is now accepted and ready to land.
Comment at: clang/include/clang/Tooling/Syntax/Nodes.h:333
+/// call-arguments:
+/// delimited_list(expression, ',', )
+/// Note: This construct is a simpli
eduucaldas added a reviewer: gribozavr2.
eduucaldas added inline comments.
Comment at: clang/unittests/Tooling/Syntax/BuildTreeTest.cpp:506
| `-'~'
-|-'decltype'
+|-'decltype' OpenParen
|-'('
This is wrong but it's just because decltype is all wrong
=
eduucaldas updated this revision to Diff 287694.
eduucaldas added a comment.
- Nits
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D86544/new/
https://reviews.llvm.org/D86544
Files:
clang/include/clang/Tooling/Syntax/Nodes.h
clang/lib/Tooling/Sy
eduucaldas created this revision.
Herald added a project: clang.
Herald added a subscriber: cfe-commits.
eduucaldas requested review of this revision.
Add support for all C++ call expressions, including those coming from
`operator()`.
A call expression's arguments are inside their own node - `Cal
