subject:"\[PATCH\] D86351\: WIP\: llvm\-buildozer"

[PATCH] D86351: WIP: llvm-buildozer

2022-04-22 Thread Alexandre Ganea via Phabricator via cfe-commits

aganea added inline comments. Comment at: llvm/lib/Analysis/MemorySSA.cpp:89 #ifdef EXPENSIVE_CHECKS -bool llvm::VerifyMemorySSA = true; +LLVM_THREAD_LOCAL bool llvm::VerifyMemorySSA = true; #else arsenm wrote: > Do command line flags like this really need to b

[PATCH] D86351: WIP: llvm-buildozer

2022-04-19 Thread Matt Arsenault via Phabricator via cfe-commits

arsenm added inline comments. Comment at: llvm/lib/Analysis/MemorySSA.cpp:89 #ifdef EXPENSIVE_CHECKS -bool llvm::VerifyMemorySSA = true; +LLVM_THREAD_LOCAL bool llvm::VerifyMemorySSA = true; #else Do command line flags like this really need to be thread local?