[PATCH] D86223: [analyzer][z3] Use more elaborate z3 variable names in debug build

mikhail.ramalho requested changes to this revision. mikhail.ramalho added a comment. This revision now requires changes to proceed. In D86223#2231991 , @steakhal wrote: > In D86223#2231959 , @mikhail.ramalho > wrot

[PATCH] D86223: [analyzer][z3] Use more elaborate z3 variable names in debug build

steakhal added inline comments. Comment at: clang/include/clang/StaticAnalyzer/Core/PathSensitive/SMTConv.h:335 +llvm::raw_svector_ostream OS(Str); +OS << PRETTY_SYMBOL_KIND << ID; +#undef PRETTY_SYMBOL_KIND xazax.hun wrote: > Maybe, in this case, it is c

[PATCH] D86223: [analyzer][z3] Use more elaborate z3 variable names in debug build

steakhal updated this revision to Diff 287197. steakhal marked 2 inline comments as done. steakhal edited the summary of this revision. steakhal added a comment. In D86223#2231959 , @mikhail.ramalho wrote: > I don't mind having it for release builds as we

[PATCH] D86223: [analyzer][z3] Use more elaborate z3 variable names in debug build

mikhail.ramalho added a comment. I don't mind having it for release builds as well, why are you applying it only for debug builds? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D86223/new/ https://reviews.llvm.org/D86223 __

[PATCH] D86223: [analyzer][z3] Use more elaborate z3 variable names in debug build

xazax.hun added inline comments. Comment at: clang/test/Analysis/z3/pretty-dump.c:15 +// CHECK: "constraints": [ +// CHECK-NEXT: { "symbol": "(reg_$[[#]]) == 3", "range": "(= reg_$[[#]] #x0003)" } + } Will this test case work with non-debug builds?

[PATCH] D86223: [analyzer][z3] Use more elaborate z3 variable names in debug build

xazax.hun accepted this revision. xazax.hun added a comment. This is what I had in mind, thanks! Comment at: clang/include/clang/StaticAnalyzer/Core/PathSensitive/SMTConv.h:335 +llvm::raw_svector_ostream OS(Str); +OS << PRETTY_SYMBOL_KIND << ID; +#undef PRETTY_SYMBOL_KI

[PATCH] D86223: [analyzer][z3] Use more elaborate z3 variable names in debug build

steakhal updated this revision to Diff 287192. steakhal edited the summary of this revision. steakhal added a comment. Use virtual getKindStr method for acquiring the kind name. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D86223/new/ https://revie

[PATCH] D86223: [analyzer][z3] Use more elaborate z3 variable names in debug build

xazax.hun added a comment. In D86223#2228855 , @steakhal wrote: > I wanted to conditionally, aka. in debug configuration override the base > implementation of the SymbolData::getKindStr I see. Yeah, that does not make much sense. I was thinking about alw

[PATCH] D86223: [analyzer][z3] Use more elaborate z3 variable names in debug build

steakhal added a comment. In D86223#2228731 , @xazax.hun wrote: > In D86223#2227353 , @steakhal wrote: > >> Eh, I'm not sure if it worth it to put these into virtual functions - as >> conditionally overriding funct

[PATCH] D86223: [analyzer][z3] Use more elaborate z3 variable names in debug build

xazax.hun added a comment. In D86223#2227353 , @steakhal wrote: > Eh, I'm not sure if it worth it to put these into virtual functions - as > conditionally overriding functions is not really a good idea. I am not sure I follow. What do you mean by conditi

[PATCH] D86223: [analyzer][z3] Use more elaborate z3 variable names in debug build

steakhal added a comment. In D86223#2226876 , @xazax.hun wrote: > Exactly, but you could return a StringRef to static storage. > > I am fine with both approach. Whichever you find cleaner. Eh, I'm not sure if it worth it to put these into virtual function

[PATCH] D86223: [analyzer][z3] Use more elaborate z3 variable names in debug build

xazax.hun added a comment. Exactly, but you could return a StringRef to static storage. I am fine with both approach. Whichever you find cleaner. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D86223/new/ https://reviews.llvm.org/D86223 ___

[PATCH] D86223: [analyzer][z3] Use more elaborate z3 variable names in debug build

steakhal added a comment. In D86223#2226630 , @xazax.hun wrote: > I wonder whether having a virtual method for symbols to get the prefix would > be cleaner (something like getKindCStr), but I do not insist. Are you implying to have something like: vir

[PATCH] D86223: [analyzer][z3] Use more elaborate z3 variable names in debug build

xazax.hun accepted this revision. xazax.hun added a comment. This revision is now accepted and ready to land. LGTM! I wonder whether having a virtual method for symbols to get the prefix would be cleaner (something like getKindCStr), but I do not insist. Repository: rG LLVM Github Monorepo

[PATCH] D86223: [analyzer][z3] Use more elaborate z3 variable names in debug build

steakhal created this revision. steakhal added reviewers: NoQ, Szelethus, vsavchenko, xazax.hun, mikhail.ramalho, ddcc. Herald added subscribers: cfe-commits, ASDenysPetrov, martong, Charusso, dkrupp, donat.nagy, a.sidorin, rnkovacs, szepet, baloghadamsoftware, whisperity. Herald added a project: