[PATCH] D86137: Add -Wno-error=unknown flag to clang-format.

fodinabor added a comment. I can reproduce the issue, but not sure what introduced this. In D86137#2460135 , @njames93 wrote: > Should the name be changed to `Wno-error-unknown`? I don't think this should be the solution, as we aimed for the common synta

[PATCH] D86137: Add -Wno-error=unknown flag to clang-format.

njames93 added a comment. Herald added a subscriber: dexonsmith. I think the `=` in the option name is confusing the option parser, ➜ clang-format --Wno-error=unknown clang-format: Unknown command line argument '--Wno-error=unknown'. Try: 'clang-format --help' clang-format: Did you mean

[PATCH] D86137: Add -Wno-error=unknown flag to clang-format.

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGf64903fd8176: Add -Wno-error=unknown flag to clang-format. (authored by fodinabor). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D86137: Add -Wno-error=unknown flag to clang-format.

MyDeveloperDay added a comment. it certainly LGTM, like I said I've had met this issue before and I think this does get around that situation where perhaps your not even using the option it's complaining about (especially if its a C++ option and you are using clang-format for C#) So yes I thin

[PATCH] D86137: Add -Wno-error=unknown flag to clang-format.

fodinabor added a comment. Okay, I requested commit access. So the patch is fine with you from a clang-format perspective? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D86137/new/ https://reviews.llvm.org/D86137 ___

[PATCH] D86137: Add -Wno-error=unknown flag to clang-format.

MyDeveloperDay added a comment. IMHO I feel that given that these changes are more wide reaching than just clang-format that it might be more correct for your to request commit access yourself. You need to own these changes, because if the llvm/Support changes fail the build or unit tests the