[PATCH] D85960: [AST][FPEnv] Keep FP options in trailing storage of CastExpr

This revision was not accepted when it landed; it landed in state "Needs Review". This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG6c8041aa0ffe: [AST][FPEnv] Keep FP options in trailing storage of

[PATCH] D85960: [AST][FPEnv] Keep FP options in trailing storage of CastExpr

rjmccall added a comment. Follow-up on my previous request. It's fine by me if you commit with that fix. Comment at: clang/lib/Analysis/BodyFarm.cpp:188 + const_cast(Arg), nullptr, VK_RValue, + FPOptionsOverride

[PATCH] D85960: [AST][FPEnv] Keep FP options in trailing storage of CastExpr

sepavloff marked 3 inline comments as done. sepavloff added a comment. In D85960#2259703 , @riccibruno wrote: >> This change allow a CallExpr to have optional FPOptionsOverride object, > > Should this be `CastExpr` instead? Yes, thank you for the catch.

[PATCH] D85960: [AST][FPEnv] Keep FP options in trailing storage of CastExpr

sepavloff updated this revision to Diff 290487. sepavloff added a comment. Updated patch Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D85960/new/ https://reviews.llvm.org/D85960 Files: clang/include/clang/AST/Expr.h clang/include/clang/AST/Exp

[PATCH] D85960: [AST][FPEnv] Keep FP options in trailing storage of CastExpr

riccibruno added a comment. > This change allow a CallExpr to have optional FPOptionsOverride object, Should this be `CastExpr` instead? > stored in trailing storage. The implementaion is made similar to the way > used in CallExpr. Nit, but that's not really similar. In the `CallExpr` case the

[PATCH] D85960: [AST][FPEnv] Keep FP options in trailing storage of CastExpr

rjmccall added a comment. Minor request, but otherwise LGTM. Comment at: clang/lib/Analysis/BodyFarm.cpp:188 + const_cast(Arg), nullptr, VK_RValue, + FPOptionsOverride()); } Can these call sites

[PATCH] D85960: [AST][FPEnv] Keep FP options in trailing storage of CastExpr

sepavloff added a comment. Any feedback? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D85960/new/ https://reviews.llvm.org/D85960 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llv

[PATCH] D85960: [AST][FPEnv] Keep FP options in trailing storage of CastExpr

sepavloff added a comment. In D85960#2218798 , @kpn wrote: > You mentioned in D85920 a need to merge > this review with that review. I don't think that's needed. This code here is > farther along. It does everything that

[PATCH] D85960: [AST][FPEnv] Keep FP options in trailing storage of CastExpr

kpn added a comment. You mentioned in D85920 a need to merge this review with that review. I don't think that's needed. This code here is farther along. It does everything that D85920 does and has necessary pieces implemented a

[PATCH] D85960: [AST][FPEnv] Keep FP options in trailing storage of CastExpr

sepavloff added a comment. Similar patch is here: https://reviews.llvm.org/D85920. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D85960/new/ https://reviews.llvm.org/D85960 ___ cfe-commits mailing list cf

[PATCH] D85960: [AST][FPEnv] Keep FP options in trailing storage of CastExpr

sepavloff created this revision. sepavloff added reviewers: rjmccall, mibintc, shafik, kpn. Herald added a subscriber: martong. Herald added a project: clang. sepavloff requested review of this revision. This change allow a CallExpr to have optional FPOptionsOverride object, stored in trailing sto