[PATCH] D85938: [OpenMP][NFC] Update check lines after D85099

2020-08-13 Thread Johannes Doerfert via Phabricator via cfe-commits
jdoerfert updated this revision to Diff 285551. jdoerfert added a comment. This revision is now accepted and ready to land. Herald added subscribers: llvm-commits, ormris, hiraditya. Herald added a project: LLVM. Resolve the root cause Repository: rG LLVM Github Monorepo CHANGES SINCE LAST AC

[PATCH] D85938: [OpenMP][NFC] Update check lines after D85099

2020-08-13 Thread Johannes Doerfert via Phabricator via cfe-commits
jdoerfert added a comment. Root cause: We sometimes, depending on the invocation and potentially other factors, use a full path and sometimes not: So wen I run this with clang locally I get this: @98 = private unnamed_addr constant [98 x i8] c";/data/src/llvm-project/clang/test/OpenMP/irbuild

[PATCH] D85938: [OpenMP][NFC] Update check lines after D85099

2020-08-13 Thread Hubert Tong via Phabricator via cfe-commits
hubert.reinterpretcast added a comment. In D85938#2216905 , @lebedev.ri wrote: > Thanks. Seems to fix the test for me FWIW, but > > 1. why wasn't this caught by anyone and all of the bots? For what it's worth, I have been affected by this and was drafting

[PATCH] D85938: [OpenMP][NFC] Update check lines after D85099

2020-08-13 Thread Johannes Doerfert via Phabricator via cfe-commits
jdoerfert planned changes to this revision. jdoerfert added a comment. Something is fishy here. Now the pre-merge tests fail... this should accept strictly more... I have to look into this, best guess: some non-determinism Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https

[PATCH] D85938: [OpenMP][NFC] Update check lines after D85099

2020-08-13 Thread Roman Lebedev via Phabricator via cfe-commits
lebedev.ri accepted this revision. lebedev.ri added a comment. This revision is now accepted and ready to land. Thanks. Seems to fix the test for me FWIW, but 1. why wasn't this caught by anyone and all of the bots? 2. what is the actual underlying problem, if any? Repository: rG LLVM Github

[PATCH] D85938: [OpenMP][NFC] Update check lines after D85099

2020-08-13 Thread Johannes Doerfert via Phabricator via cfe-commits
jdoerfert created this revision. jdoerfert added a reviewer: lebedev.ri. Herald added subscribers: guansong, bollu, yaxunl. Herald added a project: clang. jdoerfert requested review of this revision. Herald added a subscriber: sstefan1. Repository: rG LLVM Github Monorepo https://reviews.llvm.o