This revision was automatically updated to reflect the committed changes.
Closed by commit rG64c0792946b7: [clang][feature] Add cxx_abi_relative_vtable
feature (authored by leonardchan).
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D85924/new/
https
ldionne accepted this revision.
ldionne added a comment.
This LGTM, but I agree someone should sign off on whether `__has_feature` is
the right approach here. @aaron.ballman ?
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D85924/new/
https://review
leonardchan added a comment.
*ping* @aaron.ballman. Would you be able to sign off on this? Otherwise, I'll
probably commit this in the next few days.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D85924/new/
https://reviews.llvm.org/D85924
___
leonardchan added a comment.
CC @aaron.ballman who committed Features.def for signing off or knowing someone
who can sign off.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D85924/new/
https://reviews.llvm.org/D85924
__
mcgrathr accepted this revision.
mcgrathr added a comment.
This revision is now accepted and ready to land.
LGTM but I'm not sure who should sign off on new `__has_feature` symbols.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D85924/new/
https://r
leonardchan updated this revision to Diff 285506.
leonardchan retitled this revision from "[clang] Add __RELATIVE_CXX_ABI_VTABLES
predefine macro" to "[clang][feature] Add cxx_abi_relative_vtable feature".
leonardchan edited the summary of this revision.
Repository:
rG LLVM Github Monorepo
CHA
