[PATCH] D85913: [SyntaxTree] Split `TreeTestBase` into header and source

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG2e4a20fd7062: [SyntaxTree] Split `TreeTestBase` into header and source (authored by eduucaldas). Repository: rG LLVM Github Monorepo CHANGES SINC

[PATCH] D85913: [SyntaxTree] Split `TreeTestBase` into header and source

eduucaldas updated this revision to Diff 285566. eduucaldas added a comment. remove static inside anonymous namespace Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D85913/new/ https://reviews.llvm.org/D85913 Files: clang/unittests/Tooling/Syntax/

[PATCH] D85913: [SyntaxTree] Split `TreeTestBase` into header and source

gribozavr2 accepted this revision. gribozavr2 added inline comments. This revision is now accepted and ready to land. Comment at: clang/unittests/Tooling/Syntax/TreeTestBase.cpp:38 +namespace { +static ArrayRef tokens(syntax::Node *N) { + assert(N->isOriginal() && "tokens of mod

[PATCH] D85913: [SyntaxTree] Split `TreeTestBase` into header and source

eduucaldas added a reviewer: gribozavr2. eduucaldas added inline comments. Comment at: clang/unittests/Tooling/Syntax/BuildTreeTest.cpp:15-17 +using namespace clang; +using namespace clang::syntax; + Following the [[ https://llvm.org/docs/CodingStandards.html#us

[PATCH] D85913: [SyntaxTree] Split `TreeTestBase` into header and source

eduucaldas updated this revision to Diff 285421. eduucaldas added a comment. Remove unused `SyntaxTreeTest::addFile` Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D85913/new/ https://reviews.llvm.org/D85913 Files: clang/unittests/Tooling/Syntax/B

[PATCH] D85913: [SyntaxTree] Split `TreeTestBase` into header and source

eduucaldas updated this revision to Diff 285416. eduucaldas added a comment. Fix the diff base Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D85913/new/ https://reviews.llvm.org/D85913 Files: clang/unittests/Tooling/Syntax/BuildTreeTest.cpp cla

[PATCH] D85913: [SyntaxTree] Split `TreeTestBase` into header and source

eduucaldas updated this revision to Diff 285413. eduucaldas added a comment. Switch to using directive on source files Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D85913/new/ https://reviews.llvm.org/D85913 Files: clang/unittests/Tooling/Syntax

[PATCH] D85913: [SyntaxTree] Split `TreeTestBase` into header and source

eduucaldas updated this revision to Diff 285401. eduucaldas added a comment. . Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D85913/new/ https://reviews.llvm.org/D85913 Files: clang/unittests/Tooling/Syntax/BuildTreeTest.cpp clang/unittests/Too

[PATCH] D85913: [SyntaxTree] Split `TreeTestBase` into header and source

eduucaldas created this revision. Herald added subscribers: cfe-commits, mgorny. Herald added a project: clang. eduucaldas requested review of this revision. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D85913 Files: clang/unittests/Tooling/Syntax/BuildTreeTest.cpp clang/un