[PATCH] D85897: [SyntaxTree] Split `TreeTest.cpp`

2020-08-13 Thread Dmitri Gribenko via Phabricator via cfe-commits
gribozavr2 accepted this revision. gribozavr2 added inline comments. This revision is now accepted and ready to land. Comment at: clang/unittests/Tooling/Syntax/BuildTreeTest.cpp:16 +namespace clang { +namespace syntax_test { namespace { Ditto, please use namesp

[PATCH] D85897: [SyntaxTree] Split `TreeTest.cpp`

2020-08-13 Thread Eduardo Caldas via Phabricator via cfe-commits
eduucaldas added a comment. We can further split `BuildTreeTest.cpp` for instance in `BuildStatementTest.cpp` and `BuildDeclTest.cpp`, I can't see many arguments towards that though. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D85897/new/ https:

[PATCH] D85897: [SyntaxTree] Split `TreeTest.cpp`

2020-08-13 Thread Eduardo Caldas via Phabricator via cfe-commits
eduucaldas created this revision. Herald added subscribers: cfe-commits, mgorny. Herald added a project: clang. eduucaldas requested review of this revision. We extract the test infrastructure into `TreeTestBase.h` and split the tests into `MutationsTest.cpp` and `BuildTreeTest.cpp` Repository: