[PATCH] D85842: Fix `NestedNameSpecifierLoc::getLocalSourceRange()`

2020-08-12 Thread Eduardo Caldas via Phabricator via cfe-commits
eduucaldas updated this revision to Diff 285265. eduucaldas added a comment. . Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D85842/new/ https://reviews.llvm.org/D85842 Files: clang/lib/AST/NestedNameSpecifier.cpp Index: clang/lib/AST/NestedNam

[PATCH] D85842: Fix `NestedNameSpecifierLoc::getLocalSourceRange()`

2020-08-12 Thread Eduardo Caldas via Phabricator via cfe-commits
eduucaldas added a comment. Unit tests will be provided once we decide that this is the way to go ;) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D85842/new/ https://reviews.llvm.org/D85842 ___ cfe-commi

[PATCH] D85842: Fix `NestedNameSpecifierLoc::getLocalSourceRange()`

2020-08-12 Thread Eduardo Caldas via Phabricator via cfe-commits
eduucaldas updated this revision to Diff 285129. eduucaldas added a comment. Update comment Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D85842/new/ https://reviews.llvm.org/D85842 Files: clang/lib/AST/NestedNameSpecifier.cpp Index: clang/lib/

[PATCH] D85842: Fix `NestedNameSpecifierLoc::getLocalSourceRange()`

2020-08-12 Thread Eduardo Caldas via Phabricator via cfe-commits
eduucaldas updated this revision to Diff 285122. eduucaldas added a comment. Don't assume the code is completely correct Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D85842/new/ https://reviews.llvm.org/D85842 Files: clang/lib/AST/NestedNameSpec

[PATCH] D85842: Fix `NestedNameSpecifierLoc::getLocalSourceRange()`

2020-08-12 Thread Eduardo Caldas via Phabricator via cfe-commits
eduucaldas created this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. eduucaldas requested review of this revision. >From the documentation comment above >`NestedNameSpecifierLoc::getLocalSourceRange()` /// Retrieve the source range covering just the last par