[PATCH] D85817: [analyzer] Fix crash with pointer to members values

vsavchenko added a comment. In D85817#2560570 , @RedDocMD wrote: > @vsavchenko, why did you chose NamedDecl instead of ValueDecl to account for > the indirect fields? I couldn't quite follow it from the discussion above. Looking at it now, I also don't k

[PATCH] D85817: [analyzer] Fix crash with pointer to members values

RedDocMD added a comment. @vsavchenko, why did you chose NamedDecl instead of ValueDecl to account for the indirect fields? I couldn't quite follow it from the discussion above. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D85817/new/ https://revi

[PATCH] D85817: [analyzer] Fix crash with pointer to members values

This revision was automatically updated to reflect the committed changes. Closed by commit rG9cbfdde2ea06: [analyzer] Fix crash with pointer to members values (authored by vsavchenko). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D85817/new/ https:/

[PATCH] D85817: [analyzer] Fix crash with pointer to members values

vsavchenko updated this revision to Diff 285360. vsavchenko added a comment. Add "no crash" comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D85817/new/ https://reviews.llvm.org/D85817 Files: clang/include/clang/StaticAnalyzer/Core/PathSens

[PATCH] D85817: [analyzer] Fix crash with pointer to members values

vsavchenko updated this revision to Diff 285358. vsavchenko added a comment. Simplify the main test Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D85817/new/ https://reviews.llvm.org/D85817 Files: clang/include/clang/StaticAnalyzer/Core/PathSensi

[PATCH] D85817: [analyzer] Fix crash with pointer to members values

NoQ accepted this revision. NoQ added a comment. This revision is now accepted and ready to land. Aha, i see, fair enough! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D85817/new/ https://reviews.llvm.org/D85817 ___

[PATCH] D85817: [analyzer] Fix crash with pointer to members values

vsavchenko added a comment. In D85817#2213435 , @NoQ wrote: > That's a fix for https://bugs.llvm.org/show_bug.cgi?id=46264. > > Your code looks great but i don't understand at a glance what the crash was > caused by and how does your code fix it, can you

[PATCH] D85817: [analyzer] Fix crash with pointer to members values

NoQ added a comment. That's a fix for https://bugs.llvm.org/show_bug.cgi?id=46264. Your code looks great but i don't understand at a glance what the crash was caused by and how does your code fix it, can you explain? Like, the original test doesn't have any `void *`s and it doesn't have any ind

[PATCH] D85817: [analyzer] Fix crash with pointer to members values

vsavchenko created this revision. vsavchenko added reviewers: NoQ, dcoughlin, xazax.hun, Szelethus. Herald added subscribers: cfe-commits, steakhal, ASDenysPetrov, martong, Charusso, dkrupp, donat.nagy, mikhail.ramalho, a.sidorin, rnkovacs, szepet, baloghadamsoftware. Herald added a project: clan