This revision was automatically updated to reflect the committed changes.
Closed by commit rGdedaf78fa714: [SystemZ][z/OS] enable trigraphs by default on
z/OS (authored by abhina.sreeskantharajan, committed by hubert.reinterpretcast).
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTI
abhina.sreeskantharajan updated this revision to Diff 285427.
abhina.sreeskantharajan added a comment.
Thanks for catching that. I fixed up the testcase.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D85722/new/
https://reviews.llvm.org/D85722
File
hubert.reinterpretcast accepted this revision.
hubert.reinterpretcast added a comment.
LGTM with suggested changes.
Comment at: clang/test/Lexer/cxx1z-trigraphs.cpp:19
+// Note, there is intentionally trailing whitespace one lines below.
// ??/
+error here;
In
abhina.sreeskantharajan updated this revision to Diff 285399.
abhina.sreeskantharajan added a comment.
Thanks Hubert for the suggestion. I've updated the lit test.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D85722/new/
https://reviews.llvm.org/D8
hubert.reinterpretcast added inline comments.
Comment at: clang/test/Lexer/cxx1z-trigraphs.cpp:24
+// notri-warning@6 {{trigraph converted}} tri-warning@6 {{trigraph converted}}
+// notri-warning@12 {{backslash and newline separated by space}}
tri-warning@12 {{backslash and newl
abhina.sreeskantharajan marked 3 inline comments as done.
abhina.sreeskantharajan added inline comments.
Comment at: clang/lib/Frontend/CompilerInvocation.cpp:2791
+ Opts.Trigraphs =
+ (!Opts.GNUMode && !Opts.MSVCCompat && !Opts.CPlusPlus17) || T.isOSzOS();
Opts.Trigraph
abhina.sreeskantharajan updated this revision to Diff 285362.
abhina.sreeskantharajan added a comment.
Thanks Hubert and Fanbo for reviewing. I updated the comment to Hubert's
suggestion, and updated both testcases as requested.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
fanbo-meng requested changes to this revision.
fanbo-meng added a comment.
This revision now requires changes to proceed.
Can you modify `clang/test/Frontend/trigraphs.cpp` and
`clang/test/Lexer/cxx1z-trigraphs.cpp` ? These tests are assuming trigraphs are
disabled by `-std=gnu++11 -fms-compatib
hubert.reinterpretcast added inline comments.
Comment at: clang/lib/Frontend/CompilerInvocation.cpp:2787-2789
// Mimicking gcc's behavior, trigraphs are only enabled if -trigraphs
- // is specified, or -std is set to a conforming mode.
+ // is specified, -std is set to a con
