eduucaldas updated this revision to Diff 284678.
eduucaldas added a comment.
Use annotations to reduce noise of expression tests
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D85713/new/
https://reviews.llvm.org/D85713
Files:
clang/unittests/Tool
gribozavr2 added inline comments.
Comment at: clang/unittests/Tooling/Syntax/TreeTest.cpp:186-187
+auto AnnotatedRanges = AnnotatedCode.ranges();
+assert(AnnotatedRanges.size() == TreeDumps.size());
+for (auto i = 0u; i < AnnotatedRanges.size(); i++) {
+ auto *An
eduucaldas added a reviewer: gribozavr2.
eduucaldas added a comment.
A proposition, upon review I'll change other tests.
One concern is that we might lose coverage while reducing noise. But I'll take
a look into that with calm when changing the tests.
Comment at: clang/unitte
eduucaldas updated this revision to Diff 284610.
eduucaldas added a comment.
Use unsigned long in the loop index
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D85713/new/
https://reviews.llvm.org/D85713
Files:
clang/unittests/Tooling/Syntax/TreeT
eduucaldas created this revision.
Herald added a project: clang.
Herald added a subscriber: cfe-commits.
eduucaldas requested review of this revision.
Repository:
rG LLVM Github Monorepo
https://reviews.llvm.org/D85713
Files:
clang/unittests/Tooling/Syntax/TreeTest.cpp
Index: clang/unittest