arsenm accepted this revision.
arsenm added a comment.
This revision is now accepted and ready to land.
Herald added a subscriber: tatianashp.
LGTM
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D85607/new/
https://reviews.llvm.org/D85607
__
nhaehnle marked an inline comment as done.
nhaehnle added inline comments.
Comment at: llvm/include/llvm/CodeGen/MachineCfgTraits.h:100
+// provide one at all. We don't want to lay a subtle performance trap here.
+abort();
+ }
arsenm wrote:
> llvm_unreac
nhaehnle updated this revision to Diff 285711.
nhaehnle added a comment.
- use llvm_unreachable
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D85607/new/
https://reviews.llvm.org/D85607
Files:
clang/include/clang/Analysis/Analyses/Dominators.h
arsenm added inline comments.
Comment at: llvm/include/llvm/CodeGen/MachineCfgTraits.h:100
+// provide one at all. We don't want to lay a subtle performance trap here.
+abort();
+ }
llvm_unreachable?
Repository:
rG LLVM Github Monorepo
CHANGES SINCE
nhaehnle created this revision.
nhaehnle added reviewers: arsenm, foad, sameerds.
Herald added subscribers: cfe-commits, msifontes, jurahul, Kayjukh, grosul1,
Joonsoo, liufengdb, aartbik, lucyrfox, mgester, arpith-jacob, antiagainst,
shauheen, jpienaar, rriddle, mehdi_amini, rogfer01, kuhar, hira
